From: Andrew Morton <akpm@osdl.org>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: tony.luck@intel.com, ak@suse.de, jschopp@austin.ibm.com,
haveblue@us.ibm.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH: 013/017](RFC) Memory hotplug for new nodes v.3. (changes from __init to __meminit)
Date: Thu, 9 Mar 2006 04:01:09 -0800 [thread overview]
Message-ID: <20060309040109.4f9c7d5c.akpm@osdl.org> (raw)
In-Reply-To: <20060308213446.003C.Y-GOTO@jp.fujitsu.com>
Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
>
> Index: pgdat6/include/linux/bootmem.h
> ===================================================================
> --- pgdat6.orig/include/linux/bootmem.h 2006-03-06 18:25:37.000000000 +0900
> +++ pgdat6/include/linux/bootmem.h 2006-03-06 21:08:05.000000000 +0900
> @@ -88,8 +88,8 @@ static inline void *alloc_remap(int nid,
> }
> #endif
>
> -extern unsigned long __initdata nr_kernel_pages;
> -extern unsigned long __initdata nr_all_pages;
> +extern unsigned long __meminitdata nr_kernel_pages;
> +extern unsigned long __meminitdata nr_all_pages;
Declaring the section for externs like this isn't very useful really. I
don't think there's any way in which the compiler can check it and the
linker will look at the definition, not at the declarations. And if we add
these, we just need to keep the declarations updated for cosmetic reasons
as you've discovered.
So I'd recommend you simply remove the __initdata tags here and leave it at
that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-03-09 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 13:42 Yasunori Goto
2006-03-09 12:01 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309040109.4f9c7d5c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=haveblue@us.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox