* [PATCH: 015/017](RFC) Memory hotplug for new nodes v.3.(allow -EEXIST of add_memory)
@ 2006-03-08 13:43 Yasunori Goto
0 siblings, 0 replies; only message in thread
From: Yasunori Goto @ 2006-03-08 13:43 UTC (permalink / raw)
To: Luck, Tony, Andi Kleen, Joel Schopp, Dave Hansen
Cc: linux-ia64, Linux Kernel ML, linux-mm, Andrew Morton
When acpi_memory_device_init() is called at boottime to
register struct memory acpi_memory_device,
acpi_bus_add() are called via acpi_driver_attach().
But it also calls ops->start() function.
It is called even if the memory blocks are initialized at
early boottime. In this case add_memory() return -EEXIST, and
the memory blocks becomes INVALID state even if it is normal.
This is patch for it.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Index: pgdat6/drivers/acpi/acpi_memhotplug.c
===================================================================
--- pgdat6.orig/drivers/acpi/acpi_memhotplug.c 2006-03-06 18:26:28.000000000 +0900
+++ pgdat6/drivers/acpi/acpi_memhotplug.c 2006-03-06 18:26:30.000000000 +0900
@@ -199,7 +199,16 @@ static int acpi_memory_enable_device(str
* Note: Assume that this function returns zero on success
*/
result = add_memory(mem_device->start_addr, mem_device->length);
- if (result) {
+ switch(result) {
+ case 0:
+ break;
+ case -EEXIST:
+ ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+ "\nmemory start=%lu size=%lu has already existed\n",
+ mem_device->start_addr,
+ mem_device->length));
+ return 0;
+ default:
ACPI_ERROR((AE_INFO, "add_memory failed"));
mem_device->state = MEMORY_INVALID_STATE;
return result;
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-08 13:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-08 13:43 [PATCH: 015/017](RFC) Memory hotplug for new nodes v.3.(allow -EEXIST of add_memory) Yasunori Goto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox