linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Nick Piggin <piggin@cyberone.com.au>, Andrew Morton <akpm@osdl.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] extend usage of lightweight mm counter operations
Date: Sat, 11 Feb 2006 00:39:44 -0600	[thread overview]
Message-ID: <20060211063944.GA2908@dmt.cnet> (raw)
In-Reply-To: <20060211054922.GA3484@dmt.cnet>

Err, parts of this are unsafe.

On Fri, Feb 10, 2006 at 11:49:22PM -0600, Marcelo Tosatti wrote:
> 
> Extend usage of Nick's lightweight mm counter operations to:
> 
> - nr_dirty: in __set_page_dirty_nobuffers and __set_page_dirty_buffers,
> where interrupts are disabled due to acquision of mapping->tree_lock.

These are good.

> - nr_page_table_pages: which is never accessed from interrupt context.
> 
> - pgfault/pgmajfault: which are never accessed from interrupt context.

These are buggy due to preemption. Shall a three underscore variant
be created to disable/enable preemption, or what?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2006-02-11  6:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-11  5:49 Marcelo Tosatti
2006-02-11  6:39 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060211063944.GA2908@dmt.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    --cc=piggin@cyberone.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox