From: Con Kolivas <kernel@kolivas.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
ck list <ck@vds.kolivas.org>,
linux-mm@kvack.org, Nick Piggin <npiggin@suse.de>,
Paul Jackson <pj@sgi.com>
Subject: Re: [PATCH] mm: Implement Swap Prefetching v22
Date: Fri, 10 Feb 2006 11:56:08 +1100 [thread overview]
Message-ID: <200602101156.09326.kernel@kolivas.org> (raw)
In-Reply-To: <43EBE3AB.1010009@jp.fujitsu.com>
On Friday 10 February 2006 11:51, KAMEZAWA Hiroyuki wrote:
> Hi,
>
> Con Kolivas wrote:
> > +void add_to_swapped_list(struct page *page)
> > +{
> > + struct swapped_entry *entry;
> > + unsigned long index;
> > +
> > + spin_lock(&swapped.lock);
> > + if (swapped.count >= swapped.maxcount) {
>
> Assume x86 system with 8G memory, swapped_maxcount is maybe 5G+ here.
> Then, swapped_entry can consume 5G/PAGE_SIZE * 16bytes = 10 M byte more
> slabs from ZONE_NORMAL. Could you add check like this?
> ==
> void add_to_swapped_list(struct page *page)
> {
> <snip>
> if (!swap_prefetch)
> return;
> spin_lcok(&spwapped.lock);
> }
> ==
Sure why not. It made testing easier to not stop adding entries to the swapped
list when it was disabled, but for release your idea makes sense. Thanks for
the suggestion.
Cheers,
Con
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-02-10 0:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-09 12:39 Con Kolivas
2006-02-09 13:29 ` Nick Piggin
2006-02-09 13:47 ` Con Kolivas
2006-02-09 14:10 ` Nick Piggin
2006-02-09 14:12 ` Con Kolivas
2006-02-09 14:21 ` Nick Piggin
2006-02-09 22:48 ` Con Kolivas
2006-02-09 14:51 ` Con Kolivas
2006-02-10 1:04 ` Con Kolivas
2006-02-09 18:04 ` Nikita Danilov
2006-02-10 0:08 ` Con Kolivas
2006-02-09 15:12 ` Paul Jackson
2006-02-09 15:33 ` Con Kolivas
2006-02-10 0:51 ` KAMEZAWA Hiroyuki
2006-02-10 0:56 ` Con Kolivas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602101156.09326.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox