From: Con Kolivas <kernel@kolivas.org>
To: ck@vds.kolivas.org
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [ck] Re: [PATCH] mm: implement swap prefetching
Date: Tue, 7 Feb 2006 12:32:52 +1100 [thread overview]
Message-ID: <200602071232.52897.kernel@kolivas.org> (raw)
In-Reply-To: <200602071229.25793.kernel@kolivas.org>
On Tue, 7 Feb 2006 12:29 pm, Con Kolivas wrote:
> On Tue, 7 Feb 2006 11:38 am, Andrew Morton wrote:
> > Con Kolivas <kernel@kolivas.org> wrote:
> > > + if (unlikely(!spin_trylock(&swapped.lock)))
> > > + goto out;
> >
> > hm, spin_trylock() should internally do unlikely(), but it doesn't.
> > (It's a bit of a mess, too).
>
> Good point. Perhaps I should submit a separate patch for this instead.
A quick look at this code made me change my mind; there's heaps that could do
with this treatment in spinlock.h. I'll let someone else tackle it.
Cheers,
Con
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-07 1:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-06 23:28 Con Kolivas
2006-02-07 0:38 ` Andrew Morton
2006-02-07 1:29 ` Con Kolivas
2006-02-07 1:32 ` Con Kolivas [this message]
2006-02-07 1:39 ` Andrew Morton
2006-02-08 3:29 ` [PATCH] mm: implement swap prefetching v21 Con Kolivas
2006-02-08 3:49 ` [ck] " Con Kolivas
2006-02-07 3:08 ` [PATCH] mm: implement swap prefetching Nick Piggin
2006-02-07 3:29 ` Nick Piggin
2006-02-07 4:02 ` Con Kolivas
2006-02-07 5:00 ` Nick Piggin
2006-02-07 6:02 ` Con Kolivas
2006-02-07 6:51 ` Nick Piggin
2006-02-07 10:54 ` Con Kolivas
2006-02-07 17:14 ` Andrew Morton
2006-02-07 20:34 ` Marcelo Tosatti
2006-02-07 22:39 ` Andi Kleen
2006-02-08 4:46 ` Paul Jackson
2006-02-08 5:06 ` Con Kolivas
2006-02-08 5:13 ` Paul Jackson
2006-02-08 5:33 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602071232.52897.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox