From: Paul Jackson <pj@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: christoph@lameter.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, manfred@colorfullife.com
Subject: Re: [RFT/PATCH] slab: consolidate allocation paths
Date: Sat, 4 Feb 2006 18:00:26 -0800 [thread overview]
Message-ID: <20060204180026.b68e9476.pj@sgi.com> (raw)
In-Reply-To: <1139070779.21489.5.camel@localhost>
This consolidation patch looks ok to me on first read, though others
are certainly more expert in this code than I am. Certainly cleanup,
ifdef reduction and consolidation of mm/slab.c is a worthwhile goal.
That code is rough for folks like me to follow.
Two issues I can see:
1) This patch increased the text size of mm/slab.o by 776
bytes (ia64 sn2_defconfig gcc 3.3.3), which should be
justified. My naive expectation would have been that
such a source code consolidation patch would be text
size neutral, or close to it.
2) You might want to hold off this patch for a few days,
until the dust settles from my memory spread patch.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-05 2:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-04 13:33 Pekka Enberg
2006-02-04 15:11 ` Christoph Lameter
2006-02-04 16:26 ` Pekka Enberg
2006-02-04 16:32 ` Pekka Enberg
2006-02-05 2:00 ` Paul Jackson [this message]
2006-02-05 3:44 ` Christoph Lameter
2006-02-05 4:36 ` Paul Jackson
2006-02-05 8:41 ` Pekka Enberg
2006-02-05 9:18 ` Pekka Enberg
2006-02-05 12:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060204180026.b68e9476.pj@sgi.com \
--to=pj@sgi.com \
--cc=christoph@lameter.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox