From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 25 Jan 2006 19:09:16 -0800 From: William Lee Irwin III Subject: Re: [patch] hugepage allocator cleanup Message-ID: <20060126030916.GI7655@holomorphy.com> References: <20060125091103.GA32653@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060125091103.GA32653@wotan.suse.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Andrew Morton , Linux Memory Management List List-ID: On Wed, Jan 25, 2006 at 10:11:03AM +0100, Nick Piggin wrote: > This is a slight rework of the mechanism for allocating "fresh" hugepages. > Comments? > -- > Insert "fresh" huge pages into the hugepage allocator by the same > means as they are freed back into it. This reduces code size and > allows enqueue_huge_page to be inlined into the hugepage free > fastpath. > Eliminate occurances of hugepages on the free list with non-zero > refcount. This can allow stricter refcount checks in future. Also > required for lockless pagecache. > Signed-off-by: Nick Piggin This patch also eliminates a leak "cleaned up" by re-clobbering the refcount on every allocation from the hugepage freelists. With respect to the lockless pagecache, the crucial aspect is to eliminate unconditional set_page_count() to 0 on pages with potentially nonzero refcounts, though closer inspection suggests the assignments removed are entirely spurious. Acked-by: William Irwin -- wli -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org