From: mel@csn.ul.ie (Mel Gorman)
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: jschopp@austin.ibm.com,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: Re: [Patch] New zone ZONE_EASY_RECLAIM take 4. (disable gfp_easy_reclaim bit)[5/8]
Date: Thu, 5 Jan 2006 09:47:26 +0000 [thread overview]
Message-ID: <20060105094726.GA14735@skynet.ie> (raw)
In-Reply-To: <20060105144247.491D.Y-GOTO@jp.fujitsu.com>
On (05/01/06 14:43), Yasunori Goto didst pronounce:
> >
> > > ===================================================================
> > > --- zone_reclaim.orig/fs/pipe.c 2005-12-16 18:36:20.000000000 +0900
> > > +++ zone_reclaim/fs/pipe.c 2005-12-16 19:15:35.000000000 +0900
> > > @@ -284,7 +284,7 @@ pipe_writev(struct file *filp, const str
> > > int error;
> > >
> > > if (!page) {
> > > - page = alloc_page(GFP_HIGHUSER);
> > > + page = alloc_page(GFP_HIGHUSER & ~__GFP_EASY_RECLAIM);
> > > if (unlikely(!page)) {
> > > ret = ret ? : -ENOMEM;
> > > break;
> >
> > That is a bit hard to understand. How about a new GFP_HIGHUSER_HARD or
> > somesuch define back in patch 1, then use it here?
>
> It looks better. Thanks for your idea.
>
There are other places where GFP_HIGHUSER is used for pages that are not easily
reclaimed. It is easier clearer to add __GFP_EASY_RECLAIM at the places you
know pages are easily reclaimed rather than removing __GFP_EASY_RECLAIM from
awkward places.
--
Mel Gorman
Part-time Phd Student
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-05 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 8:53 Yasunori Goto
2006-01-03 21:34 ` Joel Schopp
2006-01-05 5:43 ` Yasunori Goto
2006-01-05 9:47 ` Mel Gorman [this message]
2006-01-05 10:59 ` Yasunori Goto
2006-01-05 11:23 ` Mel Gorman
2006-01-06 1:36 ` [Lhms-devel] " Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060105094726.GA14735@skynet.ie \
--to=mel@csn.ul.ie \
--cc=jschopp@austin.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox