* [Patch] New zone ZONE_EASY_RECLAIM take 3. (define ZONE_EASY_RECLAIM)[2/5]
@ 2005-12-10 11:02 Yasunori Goto
2005-12-15 21:58 ` Joel Schopp
0 siblings, 1 reply; 3+ messages in thread
From: Yasunori Goto @ 2005-12-10 11:02 UTC (permalink / raw)
To: linux-mm, Linux Hotplug Memory Support; +Cc: Joel Schopp
This defines new zone ZONE_EASY_RECLAIM.
ZONES_SHIFT becomes 3.
And this patch add member of sysctl_lowmem_reserve_ratio[].
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Index: zone_reclaim/include/linux/mmzone.h
===================================================================
--- zone_reclaim.orig/include/linux/mmzone.h 2005-12-10 17:12:58.000000000 +0900
+++ zone_reclaim/include/linux/mmzone.h 2005-12-10 17:13:16.000000000 +0900
@@ -73,9 +73,10 @@ struct per_cpu_pageset {
#define ZONE_DMA32 1
#define ZONE_NORMAL 2
#define ZONE_HIGHMEM 3
+#define ZONE_EASY_RECLAIM 4
-#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */
-#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */
+#define MAX_NR_ZONES 5 /* Sync this with ZONES_SHIFT */
+#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */
/*
Index: zone_reclaim/mm/page_alloc.c
===================================================================
--- zone_reclaim.orig/mm/page_alloc.c 2005-12-10 17:13:15.000000000 +0900
+++ zone_reclaim/mm/page_alloc.c 2005-12-10 17:15:10.000000000 +0900
@@ -66,7 +66,7 @@ static void fastcall free_hot_cold_page(
* TBD: should special case ZONE_DMA32 machines here - in those we normally
* don't need any ZONE_NORMAL reservation
*/
-int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 32 };
+int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 256, 32 ,32};
EXPORT_SYMBOL(totalram_pages);
@@ -77,7 +77,7 @@ EXPORT_SYMBOL(totalram_pages);
struct zone *zone_table[1 << ZONETABLE_SHIFT] __read_mostly;
EXPORT_SYMBOL(zone_table);
-static char *zone_names[MAX_NR_ZONES] = { "DMA", "DMA32", "Normal", "HighMem" };
+static char *zone_names[MAX_NR_ZONES] = { "DMA", "DMA32", "Normal", "HighMem", "Easy Reclaim"};
int min_free_kbytes = 1024;
unsigned long __initdata nr_kernel_pages;
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] New zone ZONE_EASY_RECLAIM take 3. (define ZONE_EASY_RECLAIM)[2/5]
2005-12-10 11:02 [Patch] New zone ZONE_EASY_RECLAIM take 3. (define ZONE_EASY_RECLAIM)[2/5] Yasunori Goto
@ 2005-12-15 21:58 ` Joel Schopp
2005-12-16 0:55 ` Yasunori Goto
0 siblings, 1 reply; 3+ messages in thread
From: Joel Schopp @ 2005-12-15 21:58 UTC (permalink / raw)
To: Yasunori Goto; +Cc: linux-mm, Linux Hotplug Memory Support
Sorry for the slow reply. Hope feedback isn't too late.
> Index: zone_reclaim/include/linux/mmzone.h
> ===================================================================
> --- zone_reclaim.orig/include/linux/mmzone.h 2005-12-10 17:12:58.000000000 +0900
> +++ zone_reclaim/include/linux/mmzone.h 2005-12-10 17:13:16.000000000 +0900
> @@ -73,9 +73,10 @@ struct per_cpu_pageset {
> #define ZONE_DMA32 1
> #define ZONE_NORMAL 2
> #define ZONE_HIGHMEM 3
> +#define ZONE_EASY_RECLAIM 4
>
> -#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */
> -#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */
> +#define MAX_NR_ZONES 5 /* Sync this with ZONES_SHIFT */
> +#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */
>
>
> /*
> Index: zone_reclaim/mm/page_alloc.c
> ===================================================================
> --- zone_reclaim.orig/mm/page_alloc.c 2005-12-10 17:13:15.000000000 +0900
> +++ zone_reclaim/mm/page_alloc.c 2005-12-10 17:15:10.000000000 +0900
> @@ -66,7 +66,7 @@ static void fastcall free_hot_cold_page(
> * TBD: should special case ZONE_DMA32 machines here - in those we normally
> * don't need any ZONE_NORMAL reservation
> */
> -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 32 };
> +int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 256, 32 ,32};
This line looks wrong. It looks you are initializing a 4 element array with 5
elements.
>
> EXPORT_SYMBOL(totalram_pages);
>
> @@ -77,7 +77,7 @@ EXPORT_SYMBOL(totalram_pages);
> struct zone *zone_table[1 << ZONETABLE_SHIFT] __read_mostly;
> EXPORT_SYMBOL(zone_table);
>
> -static char *zone_names[MAX_NR_ZONES] = { "DMA", "DMA32", "Normal", "HighMem" };
> +static char *zone_names[MAX_NR_ZONES] = { "DMA", "DMA32", "Normal", "HighMem", "Easy Reclaim"};
> int min_free_kbytes = 1024;
>
> unsigned long __initdata nr_kernel_pages;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] New zone ZONE_EASY_RECLAIM take 3. (define ZONE_EASY_RECLAIM)[2/5]
2005-12-15 21:58 ` Joel Schopp
@ 2005-12-16 0:55 ` Yasunori Goto
0 siblings, 0 replies; 3+ messages in thread
From: Yasunori Goto @ 2005-12-16 0:55 UTC (permalink / raw)
To: Joel Schopp; +Cc: linux-mm, Linux Hotplug Memory Support
> Sorry for the slow reply. Hope feedback isn't too late.
Not late. :-)
> > /*
> > Index: zone_reclaim/mm/page_alloc.c
> > ===================================================================
> > --- zone_reclaim.orig/mm/page_alloc.c 2005-12-10 17:13:15.000000000 +0900
> > +++ zone_reclaim/mm/page_alloc.c 2005-12-10 17:15:10.000000000 +0900
> > @@ -66,7 +66,7 @@ static void fastcall free_hot_cold_page(
> > * TBD: should special case ZONE_DMA32 machines here - in those we normally
> > * don't need any ZONE_NORMAL reservation
> > */
> > -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 32 };
> > +int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 256, 32 ,32};
>
> This line looks wrong. It looks you are initializing a 4 element array with 5
> elements.
Oops. I made a mistake. Thanks.
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-16 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-10 11:02 [Patch] New zone ZONE_EASY_RECLAIM take 3. (define ZONE_EASY_RECLAIM)[2/5] Yasunori Goto
2005-12-15 21:58 ` Joel Schopp
2005-12-16 0:55 ` Yasunori Goto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox