From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-mm <linux-mm@kvack.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>,
Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: [Patch] Fix calculation of grow_pgdat_span() in mm/memory_hotplug.c
Date: Tue, 13 Dec 2005 22:20:35 +0900 [thread overview]
Message-ID: <20051213220842.9C02.Y-GOTO@jp.fujitsu.com> (raw)
Dave-san.
CC: Andrew-san.
I realized 2.6.15-rc5 still has a bug for memory hotplug.
The calculation for node_spanned_pages at grow_pgdat_span() is
clearly wrong. This is patch for it.
(Please see grow_zone_span() to compare. It is correct.)
Thanks.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Index: zone_reclaim/mm/memory_hotplug.c
===================================================================
--- zone_reclaim.orig/mm/memory_hotplug.c 2005-12-13 21:38:16.000000000 +0900
+++ zone_reclaim/mm/memory_hotplug.c 2005-12-13 21:39:14.000000000 +0900
@@ -104,7 +104,7 @@ static void grow_pgdat_span(struct pglis
pgdat->node_start_pfn = start_pfn;
if (end_pfn > old_pgdat_end_pfn)
- pgdat->node_spanned_pages = end_pfn - pgdat->node_spanned_pages;
+ pgdat->node_spanned_pages = end_pfn - pgdat->node_start_pfn;
}
int online_pages(unsigned long pfn, unsigned long nr_pages)
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2005-12-13 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 13:20 Yasunori Goto [this message]
2005-12-13 16:49 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213220842.9C02.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox