* [patch] Fix Kconfig of DMA32 for ia64
@ 2005-12-10 11:05 Yasunori Goto
2005-12-11 2:31 ` Andrew Morton
2005-12-11 15:05 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Yasunori Goto @ 2005-12-10 11:05 UTC (permalink / raw)
To: Andrew Morton, linux-mm; +Cc: Luck, Tony
Andew-san.
I realized ZONE_DMA32 on -mm has a trivial bug at Kconfig for ia64.
In include/linux/gfp.h on 2.6.15-rc5-mm1, CONFIG is define like
followings.
#ifdef CONFIG_DMA_IS_DMA32
#define __GFP_DMA32 ((__force gfp_t)0x01) /* ZONE_DMA is ZONE_DMA32
*/
:
:
So, CONFIG_"ZONE"_DMA_IS_DMA32 is clearly wrong.
This is patch for it.
Thanks.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Index: zone_reclaim/arch/ia64/Kconfig
===================================================================
--- zone_reclaim.orig/arch/ia64/Kconfig 2005-12-06 13:48:35.000000000 +0900
+++ zone_reclaim/arch/ia64/Kconfig 2005-12-06 14:52:39.000000000 +0900
@@ -58,7 +58,7 @@ config IA64_UNCACHED_ALLOCATOR
bool
select GENERIC_ALLOCATOR
-config ZONE_DMA_IS_DMA32
+config DMA_IS_DMA32
bool
default y
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] Fix Kconfig of DMA32 for ia64
2005-12-10 11:05 [patch] Fix Kconfig of DMA32 for ia64 Yasunori Goto
@ 2005-12-11 2:31 ` Andrew Morton
2005-12-11 15:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2005-12-11 2:31 UTC (permalink / raw)
To: Yasunori Goto; +Cc: linux-mm, tony.luck
Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
>
> Andew-san.
>
> I realized ZONE_DMA32 on -mm has a trivial bug at Kconfig for ia64.
> In include/linux/gfp.h on 2.6.15-rc5-mm1, CONFIG is define like
> followings.
>
> #ifdef CONFIG_DMA_IS_DMA32
> #define __GFP_DMA32 ((__force gfp_t)0x01) /* ZONE_DMA is ZONE_DMA32
> */
> :
> :
>
> So, CONFIG_"ZONE"_DMA_IS_DMA32 is clearly wrong.
> This is patch for it.
>
> Thanks.
>
> Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
>
> Index: zone_reclaim/arch/ia64/Kconfig
> ===================================================================
> --- zone_reclaim.orig/arch/ia64/Kconfig 2005-12-06 13:48:35.000000000 +0900
> +++ zone_reclaim/arch/ia64/Kconfig 2005-12-06 14:52:39.000000000 +0900
> @@ -58,7 +58,7 @@ config IA64_UNCACHED_ALLOCATOR
> bool
> select GENERIC_ALLOCATOR
>
> -config ZONE_DMA_IS_DMA32
> +config DMA_IS_DMA32
> bool
> default y
>
Thanks.
Tony, nothing in ia64 land seems to be using this, so no testing should be
needed - I'll queue this up for 2.6.15.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] Fix Kconfig of DMA32 for ia64
2005-12-10 11:05 [patch] Fix Kconfig of DMA32 for ia64 Yasunori Goto
2005-12-11 2:31 ` Andrew Morton
@ 2005-12-11 15:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2005-12-11 15:05 UTC (permalink / raw)
To: Yasunori Goto; +Cc: Andrew Morton, linux-mm, Luck, Tony
On Sat, Dec 10, 2005 at 08:05:16PM +0900, Yasunori Goto wrote:
> Andew-san.
>
> I realized ZONE_DMA32 on -mm has a trivial bug at Kconfig for ia64.
> In include/linux/gfp.h on 2.6.15-rc5-mm1, CONFIG is define like
> followings.
>
> #ifdef CONFIG_DMA_IS_DMA32
> #define __GFP_DMA32 ((__force gfp_t)0x01) /* ZONE_DMA is ZONE_DMA32
> */
> :
> :
>
> So, CONFIG_"ZONE"_DMA_IS_DMA32 is clearly wrong.
> This is patch for it.
Given that apparently no one cared we should just kill it and give ia64
a proper ZONE_DMA32 post 2.6.15. No one else tried to use it anyway.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-11 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-10 11:05 [patch] Fix Kconfig of DMA32 for ia64 Yasunori Goto
2005-12-11 2:31 ` Andrew Morton
2005-12-11 15:05 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox