linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: linux-mm@kvack.org, tony.luck@intel.com
Subject: Re: [patch] Fix Kconfig of DMA32 for ia64
Date: Sat, 10 Dec 2005 18:31:01 -0800	[thread overview]
Message-ID: <20051210183101.2386a7e8.akpm@osdl.org> (raw)
In-Reply-To: <20051210194521.4832.Y-GOTO@jp.fujitsu.com>

Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
>
> Andew-san.
> 
> I realized ZONE_DMA32 on -mm has a trivial bug at Kconfig for ia64.
> In include/linux/gfp.h on 2.6.15-rc5-mm1, CONFIG is define like
> followings.
> 
> #ifdef CONFIG_DMA_IS_DMA32
> #define __GFP_DMA32	((__force gfp_t)0x01)	/* ZONE_DMA is ZONE_DMA32
> */
>        :
>        :
> 
> So, CONFIG_"ZONE"_DMA_IS_DMA32 is clearly wrong.
> This is patch for it.
> 
> Thanks.
> 
> Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
> 
> Index: zone_reclaim/arch/ia64/Kconfig
> ===================================================================
> --- zone_reclaim.orig/arch/ia64/Kconfig	2005-12-06 13:48:35.000000000 +0900
> +++ zone_reclaim/arch/ia64/Kconfig	2005-12-06 14:52:39.000000000 +0900
> @@ -58,7 +58,7 @@ config IA64_UNCACHED_ALLOCATOR
>  	bool
>  	select GENERIC_ALLOCATOR
>  
> -config ZONE_DMA_IS_DMA32
> +config DMA_IS_DMA32
>  	bool
>  	default y
>  

Thanks.

Tony, nothing in ia64 land seems to be using this, so no testing should be
needed - I'll queue this up for 2.6.15.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2005-12-11  2:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-10 11:05 Yasunori Goto
2005-12-11  2:31 ` Andrew Morton [this message]
2005-12-11 15:05 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051210183101.2386a7e8.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    --cc=tony.luck@intel.com \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox