From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-mm@kvack.org,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: [RFC 1/3] Framework for accurate node based statistics
Date: Tue, 6 Dec 2005 20:26:03 +0100 [thread overview]
Message-ID: <20051206192603.GX11190@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0512061105220.19475@schroedinger.engr.sgi.com>
On Tue, Dec 06, 2005 at 11:08:42AM -0800, Christoph Lameter wrote:
> On Tue, 6 Dec 2005, Andi Kleen wrote:
>
> > > +static inline void mod_node_page_state(int node, enum node_stat_item item, int delta)
> > > +{
> > > + vm_stat_diff[get_cpu()][node][item] += delta;
> > > + put_cpu();
> >
> > Instead of get/put_cpu I would use a local_t. This would give much better code
> > on i386/x86-64. I have some plans to port over all the MM statistics counters
> > over to local_t, still stuck, but for new code it should be definitely done.
>
> Yuck. That code uses atomic operations and is not aware of atomic64_t.
Hmm? What code are you looking at?
At least i386/x86-64/generic don't use any atomic operations, just
normal non atomic on bus but atomic for interrupts local rmw.
Do you actually need 64bit?
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-12-06 19:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 18:28 Christoph Lameter
2005-12-06 18:28 ` [RFC 2/3] Make nr_mapped a per node counter Christoph Lameter
2005-12-06 23:05 ` Nick Piggin
2005-12-06 18:28 ` [RFC 3/3] Make nr_pagecache " Christoph Lameter
2005-12-06 18:35 ` [RFC 1/3] Framework for accurate node based statistics Andi Kleen
2005-12-06 19:08 ` Christoph Lameter
2005-12-06 19:26 ` Andi Kleen [this message]
2005-12-06 19:36 ` Christoph Lameter
2005-12-06 20:06 ` Andi Kleen
2005-12-06 22:52 ` Christoph Lameter
2005-12-07 5:50 ` Keith Owens
2005-12-07 18:24 ` Christoph Lameter
2005-12-06 23:08 ` Nick Piggin
2005-12-06 23:37 ` Christoph Lameter
2005-12-06 23:40 ` Christoph Lameter
2005-12-07 6:44 ` Nick Piggin
2005-12-07 18:27 ` Christoph Lameter
2005-12-07 22:59 ` Nick Piggin
2005-12-08 0:02 ` Christoph Lameter
2005-12-08 0:13 ` Nick Piggin
2005-12-08 0:35 ` Christoph Lameter
2005-12-07 18:39 Luck, Tony
2005-12-07 18:47 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051206192603.GX11190@wotan.suse.de \
--to=ak@suse.de \
--cc=clameter@engr.sgi.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox