From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: nickpiggin@yahoo.com.au, rohit.seth@intel.com, torvalds@osdl.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Cleanup of __alloc_pages
Date: Sat, 12 Nov 2005 23:12:11 -0800 [thread overview]
Message-ID: <20051112231211.372be3a9.akpm@osdl.org> (raw)
In-Reply-To: <20051112211429.294b3783.pj@sgi.com>
Paul Jackson <pj@sgi.com> wrote:
>
> fs/xfs/linux-2.6/xfs_buf.c has:
> aentry = kmalloc(sizeof(a_list_t), GFP_ATOMIC & ~__GFP_HIGH);
That's a reasonable thing to do, actually.
GFP_ATOMIC means "don't sleep" (!__GFP_WAIT) and "use emergency pools"
(__GFP_HIGH).
XFS is saying "don't sleep" and "don't use the emergency pools".
Yes, the fact that GFP_ATOMIC also implies "use the emergency pool" is
unfortunate, and perhaps the two should always have been separated out, at
least to make the programmer think about whether the code really needs
access to the emergency pools. Usually it does.
But I haven't seen much sign that it's causing any problems.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-13 7:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 1:43 Rohit, Seth
2005-11-08 1:53 ` Andrew Morton
2005-11-08 2:16 ` Rohit Seth
2005-11-08 2:44 ` Andrew Morton
2005-11-08 3:47 ` Nick Piggin
2005-11-08 5:44 ` Paul Jackson
2005-11-08 6:00 ` Nick Piggin
2005-11-08 6:22 ` Paul Jackson
2005-11-08 18:17 ` Rohit Seth
2005-11-08 19:54 ` Paul Jackson
2005-11-09 2:52 ` Nick Piggin
2005-11-13 5:09 ` Paul Jackson
2005-11-13 5:14 ` Paul Jackson
2005-11-13 7:00 ` Nathan Scott
2005-11-13 7:12 ` Andrew Morton [this message]
2005-11-13 7:47 ` Paul Jackson
2005-11-08 3:07 ` Paul Jackson
2005-11-08 5:31 ` Nick Piggin
2005-11-09 0:17 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051112231211.372be3a9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
--cc=rohit.seth@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox