From: Arnd Bergmann <arnd@arndb.de>
To: Andy Whitcroft <apw@shadowen.org>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] powerpc: mem_init crash for sparsemem
Date: Fri, 4 Nov 2005 22:43:48 +0100 [thread overview]
Message-ID: <200511042243.49661.arnd@arndb.de> (raw)
In-Reply-To: <436BC20B.9070704@shadowen.org>
On Freedag 04 November 2005 21:18, Andy Whitcroft wrote:
> Would it not make sense to use pfn_valid(), as that is not sparsemem
> specific? Not looked at the code in question specifically, but if you
> can use section_has_mem_map() it should be equivalent:
>
> if (!pfn_valid(pgdat->node_start_pfn + i))
> continue;
>
> Want to spin us a patch and I'll give it some general testing.
Yes, I guess pfn_valid() is the function I was looking for, thanks
for pointing that out.
Unfortunately, I don't have access to the machine over the weekend,
so I won't be able to test that until Monday.
Arnd <><
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2005-11-04 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 15:31 Arnd Bergmann
2005-11-04 20:18 ` Andy Whitcroft
2005-11-04 20:57 ` Mike Kravetz
2005-11-04 21:59 ` Arnd Bergmann
2005-11-04 21:43 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511042243.49661.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox