From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 29 Oct 2005 20:06:34 -0700 From: Paul Jackson Subject: Re: [PATCH]: Clean up of __alloc_pages Message-Id: <20051029200634.778a57d6.pj@sgi.com> In-Reply-To: <436430BA.4010606@yahoo.com.au> References: <20051028183326.A28611@unix-os.sc.intel.com> <20051029184728.100e3058.pj@sgi.com> <4364296E.1080905@yahoo.com.au> <20051029191946.1832adaf.pj@sgi.com> <436430BA.4010606@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: rohit.seth@intel.com, akpm@osdl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Nick, replying to pj: > > And if it is inlined, then are you expecting to also have an out of > > line copy, for use by the call to it from mm/swap_prefetch.c > > prefetch_get_page()? > > > > No, that shouldn't be there though. > > > Adding the 'inline' keyword increases my kernel text size by > > 1448 bytes, for the extra copy of this code used inline from > > the call to it from mm/page_alloc.c:get_page_from_freelist(). > > Is that really worth it? > > > > Hmm, where is the other callsite? The other callsite is mm/swap_prefetch.c:prefetch_get_page(), from Con Kolivas's mm-implement-swap-prefetching.patch patch in *-mm, dated about six days ago. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org