From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 27 Oct 2005 13:31:04 -0500 From: Dean Roe Subject: Re: [ PATCH ] - Avoid slow TLB purges on SGI Altix systems Message-ID: <20051027183104.GA12888@sgi.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: "Luck, Tony" Cc: Dean Roe , linux-ia64@vger.kernel.org, linux-mm@kvack.org List-ID: On Thu, Oct 27, 2005 at 09:01:53AM -0700, Luck, Tony wrote: > - if (mm != current->active_mm) { > - /* this does happen, but perhaps it's not worth optimizing for? */ > -#ifdef CONFIG_SMP > - flush_tlb_all(); > -#else > - mm->context = 0; > -#endif > - return; > - } > > Your patch moves this secion of code up to ia64_global_tlb_purge(), > but the new code that is added there doesn't include the UP case > where mm->context is set to zero. > > -Tony > flush_tlb_range() only calls platform_global_tlb_purge() for CONFIG_SMP, so there's no point in having that code in ia64_global_tlb_purge(). Dean -- Dean Roe Silicon Graphics, Inc. roe@sgi.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org