From: Dean Roe <roe@sgi.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Dean Roe <roe@sgi.com>, linux-ia64@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [ PATCH ] - Avoid slow TLB purges on SGI Altix systems
Date: Thu, 27 Oct 2005 13:31:04 -0500 [thread overview]
Message-ID: <20051027183104.GA12888@sgi.com> (raw)
In-Reply-To: <B8E391BBE9FE384DAA4C5C003888BE6F04C8CF40@scsmsx401.amr.corp.intel.com>
On Thu, Oct 27, 2005 at 09:01:53AM -0700, Luck, Tony wrote:
> - if (mm != current->active_mm) {
> - /* this does happen, but perhaps it's not worth optimizing for? */
> -#ifdef CONFIG_SMP
> - flush_tlb_all();
> -#else
> - mm->context = 0;
> -#endif
> - return;
> - }
>
> Your patch moves this secion of code up to ia64_global_tlb_purge(),
> but the new code that is added there doesn't include the UP case
> where mm->context is set to zero.
>
> -Tony
>
flush_tlb_range() only calls platform_global_tlb_purge() for CONFIG_SMP,
so there's no point in having that code in ia64_global_tlb_purge().
Dean
--
Dean Roe
Silicon Graphics, Inc.
roe@sgi.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-27 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 16:01 Luck, Tony
2005-10-27 18:31 ` Dean Roe [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-27 20:41 [PATCH] " Dean Roe
2005-10-27 18:41 [ PATCH ] " Luck, Tony
2005-10-27 18:44 ` Dean Roe
2005-10-14 19:55 Dean Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051027183104.GA12888@sgi.com \
--to=roe@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox