From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ray Bryant" Subject: Re: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface Date: Fri, 21 Oct 2005 11:18:09 -0500 References: <20051020225935.19761.57434.sendpatchset@schroedinger.engr.sgi.com> <20051021081553.50716b97.pj@sgi.com> In-Reply-To: MIME-Version: 1.0 Message-ID: <200510211118.10886.raybry@mpdtxmail.amd.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Paul Jackson , KAMEZAWA Hiroyuki , Simon.Derr@bull.net, akpm@osdl.org, kravetz@us.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, magnus.damm@gmail.com, marcelo.tosatti@cyclades.com List-ID: On Friday 21 October 2005 10:47, Christoph Lameter wrote: > On Fri, 21 Oct 2005, Paul Jackson wrote: > > * Christoph - what is the permissions check on sys_migrate_pages()? > > It would seem inappropriate for 'guest' to be able to move the > > memory of 'root'. > > The check is missing. > That code used to be there. Basically the check was that if you could legally send a signal to the process, you could migrate its memory. Go back and look and my patches for this. Why was this dropped, arbitrarily? > Maybe we could add: > > if (!capable(CAP_SYS_RESOURCE)) > return -EPERM; > > Then we may also decide that root can move any process anywhere and drop > the retrieval of the mems_allowed from the other task. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Ray Bryant AMD Performance Labs Austin, Tx 512-602-0038 (o) 512-507-7807 (c) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org