From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, lhms-devel@lists.sourceforge.net, ak@suse.de
Subject: Re: [PATCH 1/2] Page migration via Swap V2: Page Eviction
Date: Mon, 17 Oct 2005 18:04:51 -0700 [thread overview]
Message-ID: <20051017180451.358f9dcc.akpm@osdl.org> (raw)
In-Reply-To: <20051018004937.3191.42181.sendpatchset@schroedinger.engr.sgi.com>
Christoph Lameter <clameter@sgi.com> wrote:
>
> + write_lock_irq(&mapping->tree_lock);
> +
> + if (page_count(page) != 2 || PageDirty(page)) {
> + write_unlock_irq(&mapping->tree_lock);
> + goto retry_later_locked;
> + }
This needs the (uncommented (grr)) smp_rmb() copied-and-pasted as well.
It's a shame about the copy-and-pasting :( Is it unavoidable?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-18 1:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-18 0:49 [PATCH 0/2] Page migration via Swap V2: Overview Christoph Lameter
2005-10-18 0:49 ` [PATCH 1/2] Page migration via Swap V2: Page Eviction Christoph Lameter
2005-10-18 1:04 ` Andrew Morton [this message]
2005-10-18 8:51 ` Nick Piggin
2005-10-18 16:38 ` Christoph Lameter
2005-10-18 8:34 ` Magnus Damm
2005-10-18 16:43 ` Christoph Lameter
2005-10-19 10:04 ` Magnus Damm
2005-10-19 15:29 ` Christoph Lameter
2005-10-19 20:32 ` Christoph Lameter
2005-10-18 0:49 ` [PATCH 2/2] Page migration via Swap V2: MPOL_MF_MOVE interface Christoph Lameter
2005-10-18 10:05 ` Magnus Damm
2005-10-18 16:46 ` Christoph Lameter
2005-10-18 3:18 ` [PATCH 0/2] Page migration via Swap V2: Overview KAMEZAWA Hiroyuki
2005-10-18 14:27 ` [Lhms-devel] " Lee Schermerhorn
2005-10-18 16:47 ` Christoph Lameter
2005-10-18 6:37 ` KAMEZAWA Hiroyuki
2005-10-18 16:50 ` Christoph Lameter
2005-10-18 12:16 ` Marcelo Tosatti
2005-10-18 16:54 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017180451.358f9dcc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox