linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: linux-mm@kvack.org
Cc: akpm@osdl.org, Mel Gorman <mel@csn.ul.ie>,
	kravetz@us.ibm.com, linux-kernel@vger.kernel.org,
	jschopp@austin.ibm.com, lhms-devel@lists.sourceforge.net
Subject: [PATCH 4/7] Fragmentation Avoidance V16: 004_largealloc_tryharder
Date: Wed,  5 Oct 2005 15:46:07 +0100 (IST)	[thread overview]
Message-ID: <20051005144607.11796.26661.sendpatchset@skynet.csn.ul.ie> (raw)
In-Reply-To: <20051005144546.11796.1154.sendpatchset@skynet.csn.ul.ie>

Fragmentation avoidance patches increase our chances of satisfying high
order allocations.  So this patch takes more than one iteration at trying
to fulfill those allocations because, unlike before, the extra iterations
are often useful.

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.14-rc3-003_fragcore/mm/page_alloc.c linux-2.6.14-rc3-004_largealloc_tryharder/mm/page_alloc.c
--- linux-2.6.14-rc3-003_fragcore/mm/page_alloc.c	2005-10-05 12:14:44.000000000 +0100
+++ linux-2.6.14-rc3-004_largealloc_tryharder/mm/page_alloc.c	2005-10-05 12:15:23.000000000 +0100
@@ -939,6 +939,7 @@ __alloc_pages(unsigned int __nocast gfp_
 	int do_retry;
 	int can_try_harder;
 	int did_some_progress;
+	int highorder_retry = 3;
 
 	might_sleep_if(wait);
 
@@ -1087,7 +1088,16 @@ rebalance:
 				goto got_pg;
 		}
 
-		out_of_memory(gfp_mask, order);
+		if (order < MAX_ORDER/2)
+			out_of_memory(gfp_mask, order);
+
+		/*
+		 * Due to low fragmentation efforts, we should try a little
+		 * harder to satisfy high order allocations
+		 */
+		if (order >= MAX_ORDER/2 && --highorder_retry > 0)
+			goto rebalance;
+
 		goto restart;
 	}
 
@@ -1104,6 +1114,8 @@ rebalance:
 			do_retry = 1;
 		if (gfp_mask & __GFP_NOFAIL)
 			do_retry = 1;
+		if (order >= MAX_ORDER/2 && --highorder_retry > 0)
+			do_retry = 1;
 	}
 	if (do_retry) {
 		blk_congestion_wait(WRITE, HZ/50);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2005-10-05 14:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-05 14:45 [PATCH 0/7] Fragmentation Avoidance V16 Mel Gorman
2005-10-05 14:45 ` [PATCH 1/7] Fragmentation Avoidance V16: 001_antidefrag_flags Mel Gorman
2005-10-06 15:11   ` Paul Jackson
2005-10-06 15:15     ` Mel Gorman
2005-10-05 14:45 ` [PATCH 2/7] Fragmentation Avoidance V16: 002_usemap Mel Gorman
2005-10-05 23:38   ` David S. Miller, Mel Gorman
2005-10-06 15:12     ` Mel Gorman
2005-10-05 14:46 ` [PATCH 3/7] Fragmentation Avoidance V16: 003_fragcore Mel Gorman
2005-10-05 16:48   ` Dave Hansen
2005-10-05 16:57     ` Mel Gorman
2005-10-05 17:14     ` Mel Gorman
2005-10-05 17:22       ` Dave Hansen
2005-10-05 17:45         ` Mel Gorman
2005-10-05 17:51           ` Dave Hansen
2005-10-05 14:46 ` Mel Gorman [this message]
2005-10-05 14:46 ` [PATCH 5/7] Fragmentation Avoidance V16: 005_fallback Mel Gorman
2005-10-05 16:49   ` Dave Hansen
2005-10-05 17:11     ` Mel Gorman
2005-10-05 16:51   ` Dave Hansen
2005-10-05 17:16     ` Mel Gorman
2005-10-05 17:20       ` Dave Hansen
2005-10-05 17:32         ` Mel Gorman
2005-10-05 16:53   ` Dave Hansen
2005-10-05 17:20     ` Mel Gorman
2005-10-05 17:25       ` Dave Hansen
2005-10-05 14:46 ` [PATCH 6/7] Fragmentation Avoidance V16: 006_percpu Mel Gorman
2005-10-05 14:46 ` [PATCH 7/7] Fragmentation Avoidance V16: 007_stats Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051005144607.11796.26661.sendpatchset@skynet.csn.ul.ie \
    --to=mel@csn.ul.ie \
    --cc=akpm@osdl.org \
    --cc=jschopp@austin.ibm.com \
    --cc=kravetz@us.ibm.com \
    --cc=lhms-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox