From: "David S. Miller" <davem@davemloft.net>
From: Mel Gorman <mel@csn.ul.ie>
To: mel@csn.ul.ie
Cc: linux-mm@kvack.org, akpm@osdl.org, kravetz@us.ibm.com,
linux-kernel@vger.kernel.org, jschopp@austin.ibm.com,
lhms-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/7] Fragmentation Avoidance V16: 002_usemap
Date: Wed, 05 Oct 2005 16:38:47 -0700 (PDT) [thread overview]
Date: Wed, 5 Oct 2005 15:45:57 +0100 (IST) [thread overview]
Message-ID: <20051005.163847.73221396.davem@davemloft.net> (raw)
In-Reply-To: <20051005144557.11796.2110.sendpatchset@skynet.csn.ul.ie>
> + unsigned int type = 0;
...
> + bitidx = pfn_to_bitidx(zone, pfn);
> + usemap = pfn_to_usemap(zone, pfn);
> +
There seems no strong reason not to use "unsigned long" for "type" and
besides that will provide the required alignment for the bitops
interfaces. "unsigned int" is not sufficient.
Then we also don't need to thing about "does this work on big-endian
64-bit" and things of that nature.
Please audit your other bitops uses for this issue.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-05 23:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 14:45 [PATCH 0/7] Fragmentation Avoidance V16 Mel Gorman
2005-10-05 14:45 ` [PATCH 1/7] Fragmentation Avoidance V16: 001_antidefrag_flags Mel Gorman
2005-10-06 15:11 ` Paul Jackson
2005-10-06 15:15 ` Mel Gorman
2005-10-05 14:45 ` [PATCH 2/7] Fragmentation Avoidance V16: 002_usemap Mel Gorman
2005-10-05 23:38 ` David S. Miller, Mel Gorman [this message]
2005-10-06 15:12 ` Mel Gorman
2005-10-05 14:46 ` [PATCH 3/7] Fragmentation Avoidance V16: 003_fragcore Mel Gorman
2005-10-05 16:48 ` Dave Hansen
2005-10-05 16:57 ` Mel Gorman
2005-10-05 17:14 ` Mel Gorman
2005-10-05 17:22 ` Dave Hansen
2005-10-05 17:45 ` Mel Gorman
2005-10-05 17:51 ` Dave Hansen
2005-10-05 14:46 ` [PATCH 4/7] Fragmentation Avoidance V16: 004_largealloc_tryharder Mel Gorman
2005-10-05 14:46 ` [PATCH 5/7] Fragmentation Avoidance V16: 005_fallback Mel Gorman
2005-10-05 16:49 ` Dave Hansen
2005-10-05 17:11 ` Mel Gorman
2005-10-05 16:51 ` Dave Hansen
2005-10-05 17:16 ` Mel Gorman
2005-10-05 17:20 ` Dave Hansen
2005-10-05 17:32 ` Mel Gorman
2005-10-05 16:53 ` Dave Hansen
2005-10-05 17:20 ` Mel Gorman
2005-10-05 17:25 ` Dave Hansen
2005-10-05 14:46 ` [PATCH 6/7] Fragmentation Avoidance V16: 006_percpu Mel Gorman
2005-10-05 14:46 ` [PATCH 7/7] Fragmentation Avoidance V16: 007_stats Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051005.163847.73221396.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=jschopp@austin.ibm.com \
--cc=kravetz@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox