From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-mm <linux-mm@kvack.org>
Subject: [patch] bug of pgdat_list connection in init_bootmem()
Date: Wed, 28 Sep 2005 22:50:31 +0900 [thread overview]
Message-ID: <20050928223844.8655.Y-GOTO@jp.fujitsu.com> (raw)
I think 2.6.14-rc2 has a bug in init_bootmem().
There are just 2 pgdat in pgdat_list even if node num is 3 or more,
because pgdat_last is not updated.
Bye.
P.S.
I would like to remove this pgdat_list, to simplify hot-add/remove
a node. and posted patch before.
http://marc.theaimsgroup.com/?l=linux-mm&m=111596924629564&w=2
http://marc.theaimsgroup.com/?l=linux-mm&m=111596953711780&w=2
I would like to repost after getting performance impact by this.
But it is very hard that I can get time to use big NUMA machine now.
So, I don't know when I will be able to repost it.
Anyway, this should be modified before remove pgdat_list.
Signed-off-by Yasunori Goto <y-goto@jp.fujitsu.com>
Index: bootmem_new/mm/bootmem.c
===================================================================
--- bootmem_new.orig/mm/bootmem.c 2005-09-23 17:42:06.000000000 +0900
+++ bootmem_new/mm/bootmem.c 2005-09-23 17:44:59.000000000 +0900
@@ -66,9 +66,10 @@ static unsigned long __init init_bootmem
pgdat->pgdat_next = NULL;
/* Add new nodes last so that bootmem always starts
searching in the first nodes, not the last ones */
- if (pgdat_last)
+ if (pgdat_last){
pgdat_last->pgdat_next = pgdat;
- else {
+ pgdat_last = pgdat;
+ } else {
pgdat_list = pgdat;
pgdat_last = pgdat;
}
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2005-09-28 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 13:50 Yasunori Goto [this message]
2005-09-28 16:42 ` Dave Hansen
2005-09-29 1:06 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050928223844.8655.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox