[PATCH] Increase maximum kmalloc size to 256K

[PATCH] Increase maximum kmalloc size to 256K

[Christoph Lameter]

The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with 
all debugging features enabled on 64 bit platforms) which will make 
kzalloc for workqueue structure entries fail. This patch increases the 
maximum slab entry size to 256K.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.14-rc2/include/linux/kmalloc_sizes.h
===================================================================
--- linux-2.6.14-rc2.orig/include/linux/kmalloc_sizes.h	2005-09-19 20:00:41.000000000 -0700
+++ linux-2.6.14-rc2/include/linux/kmalloc_sizes.h	2005-09-22 12:41:19.000000000 -0700
@@ -19,8 +19,8 @@
 	CACHE(32768)
 	CACHE(65536)
 	CACHE(131072)
-#ifndef CONFIG_MMU
 	CACHE(262144)
+#ifndef CONFIG_MMU
 	CACHE(524288)
 	CACHE(1048576)
 #ifdef CONFIG_LARGE_ALLOCS

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Increase maximum kmalloc size to 256K

[Andrew Morton]

Christoph Lameter <clameter@engr.sgi.com> wrote:
>
>  The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with 
>  all debugging features enabled on 64 bit platforms)

Would it be better to use alloc_percpu() in there?  Bearing in mind that
one day we'll probably have an alloc_percpu() which incurs one less
indirection and which allocates things node-affinely.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Increase maximum kmalloc size to 256K

[Christoph Lameter]

On Thu, 22 Sep 2005, Andrew Morton wrote:

> Christoph Lameter <clameter@engr.sgi.com> wrote:
> >
> >  The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with 
> >  all debugging features enabled on 64 bit platforms)
> 
> Would it be better to use alloc_percpu() in there?  Bearing in mind that
> one day we'll probably have an alloc_percpu() which incurs one less
> indirection and which allocates things node-affinely.

Yes I am working on a patch like that right now. But there is still the 
danger that other structures also may get big in the future. It would 
be best to raise the limit.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Increase maximum kmalloc size to 256K

[Matthew Wilcox]

On Thu, Sep 22, 2005 at 01:55:43PM -0700, Christoph Lameter wrote:
> On Thu, 22 Sep 2005, Andrew Morton wrote:
> 
> > Christoph Lameter <clameter@engr.sgi.com> wrote:
> > >
> > >  The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with 
> > >  all debugging features enabled on 64 bit platforms)
> > 
> > Would it be better to use alloc_percpu() in there?  Bearing in mind that
> > one day we'll probably have an alloc_percpu() which incurs one less
> > indirection and which allocates things node-affinely.
> 
> Yes I am working on a patch like that right now. But there is still the 
> danger that other structures also may get big in the future. It would 
> be best to raise the limit.

It would be better to leave the limit alone so other structures which
get ridiculously big are also caught and fixed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>