From: Dave Hansen <haveblue@us.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Dave Hansen <haveblue@us.ibm.com>
Subject: [RFC][PATCH 1/4] build_zonelists(): create zone_index_to_type() helper
Date: Tue, 20 Sep 2005 10:23:09 -0700 [thread overview]
Message-ID: <20050920172309.5C36CE4C@kernel.beaverton.ibm.com> (raw)
In-Reply-To: <20050920172303.8CD9190C@kernel.beaverton.ibm.com>
The two build_zonelists() do identical conversions from a
zone index variable (__GFP_*) to a zone type variable
(ZONE_*). Create a common helper.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
---
memhotplug-dave/mm/page_alloc.c | 24 ++++++++++++++----------
1 files changed, 14 insertions(+), 10 deletions(-)
diff -puN mm/page_alloc.c~B1-build_zonelists_unification mm/page_alloc.c
--- memhotplug/mm/page_alloc.c~B1-build_zonelists_unification 2005-09-14 09:32:37.000000000 -0700
+++ memhotplug-dave/mm/page_alloc.c 2005-09-14 09:32:37.000000000 -0700
@@ -1451,6 +1451,18 @@ static int __init build_zonelists_node(p
return j;
}
+static inline zone_index_to_type(int index)
+{
+ int type = ZONE_NORMAL;
+
+ if (index & __GFP_HIGHMEM)
+ type = ZONE_HIGHMEM;
+ if (index & __GFP_DMA)
+ type = ZONE_DMA;
+ return type;
+}
+
+
#ifdef CONFIG_NUMA
#define MAX_NODE_LOAD (num_online_nodes())
static int __initdata node_load[MAX_NUMNODES];
@@ -1547,11 +1559,7 @@ static void __init build_zonelists(pg_da
zonelist = pgdat->node_zonelists + i;
for (j = 0; zonelist->zones[j] != NULL; j++);
- k = ZONE_NORMAL;
- if (i & __GFP_HIGHMEM)
- k = ZONE_HIGHMEM;
- if (i & __GFP_DMA)
- k = ZONE_DMA;
+ k = zone_index_to_type(i);
j = build_zonelists_node(NODE_DATA(node), zonelist, j, k);
zonelist->zones[j] = NULL;
@@ -1572,11 +1580,7 @@ static void __init build_zonelists(pg_da
zonelist = pgdat->node_zonelists + i;
j = 0;
- k = ZONE_NORMAL;
- if (i & __GFP_HIGHMEM)
- k = ZONE_HIGHMEM;
- if (i & __GFP_DMA)
- k = ZONE_DMA;
+ k = zone_index_to_type(i);
j = build_zonelists_node(pgdat, zonelist, j, k);
/*
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-09-20 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 17:23 [RFC][PATCH 0/4] unify both copies of build_zonelists() Dave Hansen
2005-09-20 17:23 ` Dave Hansen [this message]
2005-09-20 17:23 ` [RFC][PATCH 2/4] build_zonelists(): abstract node_load[] operations Dave Hansen
2005-09-20 17:23 ` [RFC][PATCH 3/4] build_zonelists() unification: don't re-zero zonelist Dave Hansen
2005-09-20 17:23 ` [RFC][PATCH 4/4] unify both copies of build_zonelists() Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920172309.5C36CE4C@kernel.beaverton.ibm.com \
--to=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox