From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Dave Hansen <haveblue@us.ibm.com>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Fix interface for memory hotplug in 2.6.13-mm3
Date: Fri, 16 Sep 2005 10:48:35 +0900 [thread overview]
Message-ID: <20050916101541.D1B1.Y-GOTO@jp.fujitsu.com> (raw)
Hi Andrew-san.
I found old unsuitable interfaces for memory hotplug in 2.6.13-mm3.
The third argument of sparse_add_one_section() was changed from mem_map
to nr_pages. And the third argument of add/remove_memory() was removed.
However, both still remain at a few place.
Could you apply this patch?
Thanks.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Index: linux-2.6.13-mm3/mm/memory_hotplug.c
===================================================================
--- linux-2.6.13-mm3.orig/mm/memory_hotplug.c 2005-09-15 19:51:36.000000000 +0900
+++ linux-2.6.13-mm3/mm/memory_hotplug.c 2005-09-15 20:19:00.000000000 +0900
@@ -39,15 +39,14 @@ static void __add_zone(struct zone *zone
}
extern int sparse_add_one_section(struct zone *zone, unsigned long start_pfn,
- struct page *mem_map);
+ int nr_pages);
int __add_section(struct zone *zone, unsigned long phys_start_pfn)
{
struct pglist_data *pgdat = zone->zone_pgdat;
int nr_pages = PAGES_PER_SECTION;
- struct page *memmap;
int ret;
- ret = sparse_add_one_section(zone, phys_start_pfn, memmap);
+ ret = sparse_add_one_section(zone, phys_start_pfn, nr_pages);
if (ret < 0)
return ret;
Index: linux-2.6.13-mm3/drivers/acpi/acpi_memhotplug.c
===================================================================
--- linux-2.6.13-mm3.orig/drivers/acpi/acpi_memhotplug.c 2005-09-15 19:51:31.000000000 +0900
+++ linux-2.6.13-mm3/drivers/acpi/acpi_memhotplug.c 2005-09-15 20:21:21.000000000 +0900
@@ -200,8 +200,7 @@ static int acpi_memory_enable_device(str
* Note: Assume that this function returns zero on success
*/
result = add_memory(mem_device->start_addr,
- (mem_device->end_addr - mem_device->start_addr) + 1,
- mem_device->read_write_attribute);
+ (mem_device->end_addr - mem_device->start_addr) + 1);
if (result) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n"));
mem_device->state = MEMORY_INVALID_STATE;
@@ -259,7 +258,7 @@ static int acpi_memory_disable_device(st
* Ask the VM to offline this memory range.
* Note: Assume that this function returns zero on success
*/
- result = remove_memory(start, len, attr);
+ result = remove_memory(start, len);
if (result) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Hot-Remove failed.\n"));
return_VALUE(result);
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2005-09-16 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-16 1:48 Yasunori Goto [this message]
2005-09-16 12:49 ` Lion Vollnhals
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050916101541.D1B1.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox