linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sonny Rao <sonny@burdell.org>
To: "Martin J. Bligh" <mbligh@mbligh.org>
Cc: Andi Kleen <ak@suse.de>, David Chinner <dgc@sgi.com>,
	Bharata B Rao <bharata@in.ibm.com>, Theodore Ts'o <tytso@mit.edu>,
	Dipankar Sarma <dipankar@in.ibm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	manfred@colorfullife.com
Subject: Re: VM balancing issues on 2.6.13: dentry cache not getting shrunk enough
Date: Wed, 14 Sep 2005 11:37:00 -0400	[thread overview]
Message-ID: <20050914153700.GA6172@kevlar.burdell.org> (raw)
In-Reply-To: <313480000.1126706276@[10.10.2.4]>

On Wed, Sep 14, 2005 at 06:57:56AM -0700, Martin J. Bligh wrote:
> >> > Second is Sonny Rao's rbtree dentry reclaim patch which is an attempt
> >> > to improve this dcache fragmentation problem.
> >> 
> >> FYI, in the past I've tried this patch to reduce dcache fragmentation on
> >> an Altix (16k pages, 62 dentries to a slab page) under heavy
> >> fileserver workloads and it had no measurable effect. It appeared
> >> that there was almost always at least one active dentry on each page
> >> in the slab.  The story may very well be different on 4k page
> >> machines, however.
> > 
> > I always thought dentry freeing would work much better if it
> > was turned upside down.
> > 
> > Instead of starting from the high level dcache lists it could
> > be driven by slab: on memory pressure slab tries to return pages with unused 
> > cache objects. In that case it should check if there are only
> > a small number of pinned objects on the page set left, and if 
> > yes use a new callback to the higher level user (=dcache) and ask them
> > to free the object.
> > 
> > The slab datastructures are not completely suited for this right now,
> > but it could be done by using one more of the list_heads in struct page
> > for slab backing pages.
> > 
> > It would probably not be very LRU but a simple hack of having slowly 
> > increasing dcache generations. Each dentry use updates the generation.
> > First slab memory freeing pass only frees objects with older generations.
> 
> If they're freeable, we should easily be able to move them, and therefore 
> compact a fragmented slab. That way we can preserve the LRU'ness of it.
> Stage 1: free the oldest entries. Stage 2: compact the slab into whole
> pages. Stage 3: free whole pages back to teh page allocator.
> 
> > Using slowly increasing generations has the advantage of timestamps
> > that you can avoid dirtying cache lines in the common case when 
> > the generation doesn't change on access (= no additional cache line bouncing)
> > and it would easily allow to tune the aging rate under stress by changing the 
> > length of the generation.
> 
> LRU algorithm may need general tweaking like this anyway ... strict LRU
> is expensive to keep.

Based on what I remember, I'd contend it isn't really LRU today, so I
wouldn't try and stick to something that we aren't doing. :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2005-09-14 15:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-11 10:57 Theodore Ts'o
2005-09-11 12:00 ` Dipankar Sarma
2005-09-12  3:16   ` Theodore Ts'o
2005-09-12  6:16     ` Martin J. Bligh
2005-09-12 12:53       ` Bharata B Rao
2005-09-13  8:47     ` Bharata B Rao
2005-09-13 21:59       ` David Chinner
2005-09-14  9:01         ` Andi Kleen
2005-09-14  9:16           ` Manfred Spraul
2005-09-14  9:43             ` Andrew Morton
2005-09-14  9:52               ` Dipankar Sarma
2005-09-14 22:44               ` Theodore Ts'o
2005-09-14  9:35           ` Andrew Morton
2005-09-14 13:57           ` Martin J. Bligh
2005-09-14 15:37             ` Sonny Rao [this message]
2005-09-15  7:21             ` Helge Hafting
2005-09-14 22:48           ` David Chinner
2005-09-14 15:48         ` Sonny Rao
2005-09-14 22:02           ` David Chinner
2005-09-14 22:40             ` Sonny Rao
2005-09-15  1:14               ` David Chinner
2005-10-06  6:27         ` [PATCH] dcache: separate slab for directory dentries David Chinner, gnb
2005-10-06 12:28           ` Dave Kleikamp
2005-10-07  3:54             ` Greg Banks
2005-10-07 13:00               ` Dave Kleikamp
2005-09-14 21:34       ` VM balancing issues on 2.6.13: dentry cache not getting shrunk enough Marcelo Tosatti
2005-09-14 21:43         ` Dipankar Sarma
2005-09-15  4:28         ` Bharata B Rao
2005-09-14 23:08       ` Marcelo Tosatti
2005-09-15  9:39         ` Bharata B Rao
2005-09-15 13:29           ` Marcelo Tosatti
2005-10-02 16:32             ` Bharata B Rao
2005-10-02 20:06               ` Marcelo
2005-10-04 13:36                 ` shrinkable cache statistics [was Re: VM balancing issues on 2.6.13: dentry cache not getting shrunk enough] Bharata B Rao
2005-10-05 21:25                   ` Marcelo Tosatti
2005-10-07  8:12                     ` Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914153700.GA6172@kevlar.burdell.org \
    --to=sonny@burdell.org \
    --cc=ak@suse.de \
    --cc=bharata@in.ibm.com \
    --cc=dgc@sgi.com \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=manfred@colorfullife.com \
    --cc=mbligh@mbligh.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox