From: "David S. Miller" <davem@davemloft.net>
From: Andi Kleen <ak@suse.de>
To: ak@suse.de
Cc: tony.luck@intel.com, clameter@engr.sgi.com,
rusty@linux.intel.com, rusty.lynch@intel.com, linux-mm@kvack.org,
prasanna@in.ibm.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, anil.s.keshavamurthy@intel.com
Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured.
Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured.
Date: Tue, 30 Aug 2005 16:56:31 -0700 (PDT) [thread overview]
Date: Wed, 31 Aug 2005 01:38:08 +0200 [thread overview]
Message-ID: <20050830.165631.122559296.davem@davemloft.net> (raw)
In-Reply-To: <200508310138.09841.ak@suse.de>
> On Wednesday 31 August 2005 01:05, Luck, Tony wrote:
> > >Please do not generate any code if the feature cannot ever be
> > >used (CONFIG_KPROBES off). With this patch we still have lots of
> > >unnecessary code being executed on each page fault.
> >
> > I can (eventually) wrap this call inside the #ifdef CONFIG_KPROBES.
>
> At least the original die notifiers were designed as a generic debugger
> interface, not a kprobes specific thing. So I don't think it's a good idea.
Me neither, I think a way too big deal is being made about
about this by the ia64 folks. Just put the dang hook in
there unconditionally already :-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2005-08-30 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 23:05 Luck, Tony
2005-08-30 23:38 ` Andi Kleen
2005-08-30 23:54 ` Christoph Lameter
2005-08-31 0:05 ` Andi Kleen
2005-08-30 23:56 ` David S. Miller, Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050830.165631.122559296.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=anil.s.keshavamurthy@intel.com \
--cc=clameter@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=prasanna@in.ibm.com \
--cc=rusty.lynch@intel.com \
--cc=rusty@linux.intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox