From: Pavel Machek <pavel@ucw.cz>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: ncunningham@cyclades.com,
Linux Memory Management <linux-mm@kvack.org>,
Hugh Dickins <hugh@veritas.com>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: PageReserved removal from swsusp
Date: Mon, 25 Jul 2005 08:59:57 +0200 [thread overview]
Message-ID: <20050725065957.GA6148@elf.ucw.cz> (raw)
In-Reply-To: <42E4852D.7010209@yahoo.com.au>
Hi!
> >I'm currently playing around with trying to reuse an existing flag
> >to get this information (instead of PageReserved). But it doesn't seem
> >like a big problem if we have to fall back to the above.
> >
>
> OK, with the attached patch (on top of the PageReserved removal patches)
> things work nicely. However I'm not sure that I really like the use of
> flags == 0xffffffff to indicate the page is unusable. For one thing it
> may confuse things that walk physical pages, and for another it can
> easily break if someone clears a flag of an 'unusable' page.
No compains from my part....
Another solution may be to use PageReserved as kind of "shift".
I.e. PageNosave == PageReserved | PageLocked, PageNosaveFree ==
PageReserved | PageFree or something like that....
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-07-25 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-25 1:38 Nick Piggin
2005-07-25 4:31 ` Nigel Cunningham
2005-07-25 4:52 ` Nick Piggin
2005-07-25 6:22 ` Nick Piggin
2005-07-25 6:59 ` Pavel Machek [this message]
2005-07-25 12:39 ` Hugh Dickins
2005-07-25 23:29 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050725065957.GA6148@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=ncunningham@cyclades.com \
--cc=nickpiggin@yahoo.com.au \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox