From: Andy Whitcroft <apw@shadowen.org>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [PATCH] i386 sparsemem: undefined early_pfn_to_nid when !NUMA
Date: Fri, 3 Jun 2005 16:00:26 +0100 [thread overview]
Message-ID: <20050603150026.GC19217@shadowen.org> (raw)
In-Reply-To: <20050527162822.EBE1D09F@kernel.beaverton.ibm.com>
Seem benign for normal use and allows testing for hotplug. Tested
on my test boxes.
Andrew please apply to -mm.
-apw
=== 8< ===
On i386, early_pfn_to_nid() is only defined when discontig.c
is compiled in. The current dependency doesn't reflect this,
probably because the default i386 config doesn't allow for
SPARSEMEM without NUMA.
But, we'll need SPARSEMEM && !NUMA for memory hotplug, and I
do this for testing anyway.
Andy, please forward on if you concur.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
diffstat sparsemem-i386-undefined-early_pfn_to_nid-when-not-NUMA
---
Kconfig | 1 +
1 files changed, 1 insertion(+)
diff -upN reference/arch/i386/Kconfig current/arch/i386/Kconfig
--- reference/arch/i386/Kconfig
+++ current/arch/i386/Kconfig
@@ -803,6 +803,7 @@ source "mm/Kconfig"
config HAVE_ARCH_EARLY_PFN_TO_NID
bool
default y
+ depends on NUMA
config HIGHPTE
bool "Allocate 3rd-level pagetables from highmem"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2005-06-03 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 16:28 Dave Hansen
2005-06-03 15:00 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603150026.GC19217@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox