linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Grant Grundler <iod00d@hp.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: linux-mm@kvack.org, linux-ia64@vger.kernel.org
Subject: Re: [RFC] vmalloc with the ability to specify a node
Date: Wed, 1 Jun 2005 18:34:21 -0700	[thread overview]
Message-ID: <20050602013421.GS25321@esmail.cup.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0506011551240.10915@schroedinger.engr.sgi.com>

On Wed, Jun 01, 2005 at 03:52:42PM -0700, Christoph Lameter wrote:
> I was surprised to see that some drivers allocate memory structures
> using vmalloc.

It's drivers I care about. :^(

grundler@gsyprf3:/usr/src/linux-2.6$ fgrep vmalloc drivers/net/*/*c
drivers/net/e1000/e1000.mod.c:  { 0xd6ee688f, "vmalloc" },
drivers/net/e1000/e1000_main.c: txdr->buffer_info = vmalloc(size);
drivers/net/e1000/e1000_main.c: rxdr->buffer_info = vmalloc(size);
drivers/net/ixgb/ixgb.mod.c:    { 0xd6ee688f, "vmalloc" },
drivers/net/ixgb/ixgb_main.c:   txdr->buffer_info = vmalloc(size);
drivers/net/ixgb/ixgb_main.c:   rxdr->buffer_info = vmalloc(size);
grundler@gsyprf3:/usr/src/linux-2.6$ fgrep vmalloc drivers/scsi/*/*c
drivers/scsi/qla2xxx/qla2xxx.mod.c:     { 0xd6ee688f, "vmalloc" },
drivers/scsi/qla2xxx/qla_os.c:#include <linux/vmalloc.h>
drivers/scsi/qla2xxx/qla_os.c:                  ha->fw_dump_buffer = (char *)vmalloc(dump_size);

Could someone explain to me why this is a bad thing on NUMA machines?
I assume it has something to do with mem locality and how the memory
is used.

> Only tested in a limited way. Boots fine. Is this worth doing?

Any difference in performance?
Any clue why it matters?

grant
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2005-06-02  1:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-01 22:52 Christoph Lameter
2005-06-02  1:34 ` Grant Grundler [this message]
2005-06-02  1:56   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050602013421.GS25321@esmail.cup.hp.com \
    --to=iod00d@hp.com \
    --cc=clameter@engr.sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox