From: Christoph Hellwig <hch@infradead.org>
To: Paul Davies <pauld@gelato.unsw.edu.au>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/15] PTI: clean page table interface
Date: Sat, 28 May 2005 09:53:27 +0100 [thread overview]
Message-ID: <20050528085327.GA19047@infradead.org> (raw)
In-Reply-To: <20050521024331.GA6984@cse.unsw.EDU.AU>
On Sat, May 21, 2005 at 12:43:31PM +1000, Paul Davies wrote:
> Here are a set of 15 patches against 2.6.12-rc4 to provide a clean
> page table interface so that alternate page tables can be fitted
> to Linux in the future. This patch set is produced on behalf of
> the Gelato research group at the University of New South Wales.
>
> LMbench results are included at the end of this patch set. The
> results are very good although the mmap latency figures were
> slightly higher than expected.
>
> I look forward to any feedback that will assist me in putting
> together a page table interface that will benefit the whole linux
> community.
I've not looked over it a lot, but your code organization is a bit odd
and non-standard:
- generic implementations for per-arch abstractions go into asm-generic
and every asm-foo/ header that wants to use it includes it. In your
case that would be an asm-generic/page_table.h for the generic 3level
page tables. Please avoid #includes for generic implementations from
architecture-independent headers guarded by CONFIG_ symbols.
- I don't think the subdirectory under mm/ makes sense. Just call the
file mm/3level-page-table.c or something.
- similar please avoid the include/mm directory. It might or might not
make sense to have a subdirectory for mm headers, but please don't
start one as part of a large patch series.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-05-28 8:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-21 2:43 Paul Davies
2005-05-21 2:53 ` [PATCH 2/15] PTI: Add general files and directories Paul Cameron Davies
2005-05-21 3:08 ` [PATCH 3/15] PTI: move mlpt behind interface Paul Cameron Davies
2005-05-21 3:15 ` [PATCH 4/15] PTI: move mlpt behind interface cont Paul Cameron Davies
2005-05-21 3:26 ` [PATCH 5/15] PTI: Finish moving mlpt behind interface Paul Cameron Davies
2005-05-21 3:47 ` [PATCH 6/15] PTI: Start calling the interface Paul Cameron Davies
2005-05-21 3:54 ` [PATCH 7/15] PTI: continue calling interface Paul Cameron Davies
2005-05-21 4:04 ` [PATCH 8/15] PTI: Keep " Paul Cameron Davies
2005-05-21 4:12 ` [PATCH 9/15] PTI: Introduce iterators Paul Cameron Davies
2005-05-21 4:19 ` [PATCH 10/15] PTI: Call iterators Paul Cameron Davies
2005-05-21 4:58 ` [PATCH 11/15] PTI: Continue calling iterators Paul Cameron Davies
2005-05-21 5:04 ` [PATCH 12/15] PTI: Finish " Paul Cameron Davies
2005-05-21 5:09 ` [PATCH 13/15] PTI: Add files and IA64 part of interface Paul Cameron Davies
2005-05-21 5:15 ` [PATCH 14/15] PTI: Move IA64 mlpt code behind interface Paul Cameron Davies
2005-05-21 5:27 ` [PATCH 15/15] PTI: Call IA64 interface Paul Cameron Davies
2005-05-21 5:46 ` PTI: Patch 10/15 URL Paul Cameron Davies
2005-05-21 5:47 ` PTI: LMbench results Paul Cameron Davies
2005-05-28 8:53 ` Christoph Hellwig [this message]
2005-05-30 5:16 ` PTI: clean page table interface Paul Davies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050528085327.GA19047@infradead.org \
--to=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=pauld@gelato.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox