Re: [ckrm-tech] [PATCH 2/6] CKRM: Core framework support

[Chandra Seetharaman <sekharan@us.ibm.com>]

On Fri, May 20, 2005 at 11:27:31AM +0900, KUROSAWA Takahiro wrote:
> Hi,
> 
> On Wed, 18 May 2005 17:32:05 -0700
> Chandra Seetharaman <sekharan@us.ibm.com> wrote:
> 
> > Index: linux-2612-rc3/mm/page_alloc.c
> > ===================================================================
> > --- linux-2612-rc3.orig/mm/page_alloc.c
> > +++ linux-2612-rc3/mm/page_alloc.c
> > @@ -752,7 +752,7 @@ __alloc_pages(unsigned int __nocast gfp_
> >  	 */
> >  	can_try_harder = (unlikely(rt_task(p)) && !in_interrupt()) || !wait;
> >  
> > -	if (!ckrm_class_limit_ok(ckrm_get_mem_class(p)))
> > +	if (!ckrm_class_limit_ok(ckrm_task_memclass(p)))
> >  		return NULL;
> >  
> >  	zones = zonelist->zones;  /* the list of zones suitable for gfp_mask */
> 
> __alloc_pages() seems to look at the limit of the interrupted task
> when an interrupt handler calls __alloc_pages().  It might be better
> not to use ckrm_class_limit_ok() in in_interrupt() case, as we can't 
> assume that the interrupt is caused by the interrupted task.

Sounds valid... I had it before that way, for for some other reasoning of
mine. will get it back.
> 
> In can_try_harder case, how about trying to reclaim pages that belong
> to the class if !ckrm_class_limit_ok() ?

Sounds a good idea. will do it.

Thanks for your comments.
> 
> Regards,
> 
> -- 
> KUROSAWA, Takahiro

-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@us.ibm.com   |      .......you may get it.
----------------------------------------------------------------------
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>