linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: mike kravetz <kravetz@us.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	haveblue@us.ibm.com
Subject: Re: [3/3] sparsemem memory model for ppc64
Date: Thu, 5 May 2005 10:53:20 -0700	[thread overview]
Message-ID: <20050505175320.GC3930@w-mikek2.ibm.com> (raw)
In-Reply-To: <E1DTQWH-0002We-I9@pinky.shadowen.org>

On Wed, May 04, 2005 at 09:30:57PM +0100, Andy Whitcroft wrote:
> +	/*
> +	 * Note presence of first (logical/coalasced) LMB which will
> +	 * contain RMO region
> +	 */
> +	start_pfn = lmb.memory.region[0].physbase >> PAGE_SHIFT;
> +	end_pfn = start_pfn + (lmb.memory.region[0].size >> PAGE_SHIFT);
> +	memory_present(0, start_pfn, end_pfn);

I need to take a close look at this again, but I think this special
handling for the RMO region in unnecessary.  I added it in the 'early
days of SPARSE' when there were some 'bootstrap' issues and we needed
to initialize some memory before setting up the bootmem bitmap.  I'm
pretty sure all those issues have gone away.

-- 
Mike
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

      parent reply	other threads:[~2005-05-05 17:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-04 20:30 Andy Whitcroft
2005-05-05  2:31 ` Olof Johansson
2005-05-05 17:37   ` Andy Whitcroft
2005-05-09 15:49     ` sparsemem ppc64 tidy flat memory comments and fix benign mempresent call Andy Whitcroft
2005-05-09 23:03       ` Joel Schopp
2005-05-10 15:45         ` Andy Whitcroft
2005-05-10 19:42           ` mike kravetz
2005-05-17 13:08           ` [PATCH] sparsemem-ppc64-flat-first-block-is-not-special Andy Whitcroft
2005-05-05 17:53 ` mike kravetz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050505175320.GC3930@w-mikek2.ibm.com \
    --to=kravetz@us.ibm.com \
    --cc=anton@samba.org \
    --cc=apw@shadowen.org \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox