From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 26 Apr 2005 12:39:31 -0700 From: Andrew Morton Subject: Re: [PATCH]: VM 7/8 cluster pageout Message-Id: <20050426123931.545f0f9c.akpm@osdl.org> In-Reply-To: <17006.27177.240316.526941@gargle.gargle.HOWL> References: <16994.40699.267629.21475@gargle.gargle.HOWL> <20050425211514.29e7c86b.akpm@osdl.org> <17006.1794.857289.487941@gargle.gargle.HOWL> <20050426023635.37ab2c38.akpm@osdl.org> <17006.27177.240316.526941@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nikita Danilov Cc: linux-mm@kvack.org List-ID: Nikita Danilov wrote: > > Andrew Morton writes: > > Nikita Danilov wrote: > > > > > > Andrew Morton writes: > > > > Nikita Danilov wrote: > > > > > > > > > > Implement pageout clustering at the VM level. > > > > > > > > I dunno... > > > > > > > > Once __mpage_writepages() has started I/O against the pivot page, I don't > > > > see that we have any guarantees that some other CPU cannot come in, > > > > truncated or reclaim all the inode's pages and then reclaimed the inode > > > > altogether. While __mpage_writepages() is still dinking with it all. > > > > > > Ah, silly me. Will __iget(page->mapping->host) in pageout_cluster() be > > > enough? We risk truncate on matching iput(), but VM scanner calls iput() > > > on inodes with ->i_nlink == 0 already (from shrink_dcache()). > > > > I have vague memories about iput() in page reclaim causing deadlocks or > > some other nastiness. Maybe not. > > Aren't you talking about > > http://marc.theaimsgroup.com/?t=108272583200001&r=1&w=2 > > by any chance? Nope, this all happened in the early 2002 timeframe. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org