linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH]: VM 7/8 cluster pageout
Date: Mon, 25 Apr 2005 21:15:14 -0700	[thread overview]
Message-ID: <20050425211514.29e7c86b.akpm@osdl.org> (raw)
In-Reply-To: <16994.40699.267629.21475@gargle.gargle.HOWL>

Nikita Danilov <nikita@clusterfs.com> wrote:
>
> Implement pageout clustering at the VM level.

I dunno...

Once __mpage_writepages() has started I/O against the pivot page, I don't
see that we have any guarantees that some other CPU cannot come in,
truncated or reclaim all the inode's pages and then reclaimed the inode
altogether.  While __mpage_writepages() is still dinking with it all.

I had something like this happening in 2.5.10(ish), but ended up deciding
it was all too complex and writeout from the LRU is rare and the pages are
probably close-by on the LRU and the elevator sorting would catch most
cases so I tossed it all out.

Plus some of your other patches make LRU-based writeout even less common.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2005-04-26  4:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-17 17:38 Nikita Danilov
2005-04-26  4:15 ` Andrew Morton [this message]
2005-04-26  9:16   ` Nikita Danilov
2005-04-26  9:36     ` Andrew Morton
2005-04-26 16:19       ` Nikita Danilov
2005-04-26 19:39         ` Andrew Morton
2005-05-02  4:12   ` William Lee Irwin III
2005-05-02  5:51     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050425211514.29e7c86b.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    --cc=nikita@clusterfs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox