From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 6 Apr 2005 14:30:13 -0700 From: Andrew Morton Subject: Re: "orphaned pagecache memleak fix" question. Message-Id: <20050406143013.72c9ca92.akpm@osdl.org> In-Reply-To: <200504061712.47244.mason@suse.com> References: <16978.46735.644387.570159@gargle.gargle.HOWL> <20050406005804.0045faf9.akpm@osdl.org> <200504061712.47244.mason@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Chris Mason Cc: nikita@clusterfs.com, Andrea@suse.de, linux-mm@kvack.org List-ID: Chris Mason wrote: > > On Wednesday 06 April 2005 03:58, Andrew Morton wrote: > > > > - wouldn't it be simpler to unconditionally remove page from LRU in > > > ->invalidatepage()? > > > > I guess that's an option, yes. If the fs cannot successfully invalidate > > the page then it can either block (as described above) or remove the page > > from the LRU. The fs then wholly owns the page. > > > > I think it would be better to make ->invalidatepage always succeed though. > > The situation is probably rare. > > In data=journal it isn't rare at all. Dropping the page from the lru would be > the best solution I think. > Does that mean that my printk comes out? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org