Re: [PATCH 3/6] CKRM: Add limit support for mem controller

[Chandra Seetharaman <sekharan@us.ibm.com>]

On Tue, Apr 05, 2005 at 10:59:02AM -0700, Dave Hansen wrote:
> On Tue, 2005-04-05 at 10:42 -0700, Chandra Seetharaman wrote:
> > On Mon, Apr 04, 2005 at 07:10:50AM -0700, Dave Hansen wrote:
> > > "DONTCARE" is also multiplexed.  It means "no guarantee" or "no limit"
> > > depending on context.  I don't think it would hurt to have one variable
> > > for each of these cases.
> > 
> > It is agnostic... and the name doesn't suggest one way or other... so, I
> > don't see a problem in multiplexing it.
> 
> I think that variable names should be as suggestive as possible.  *So*
> suggestive that I know what they actually do. :)

I think you mean the macro... It does mean it.... it is a DONT CARE :) be
it limit or guarantee...

> 
> > > What does "impl" stand for, anyway?  implied?  implicit? implemented?
> > 
> > I meant implicit... you can also say implied.... will add in comments to
> > the dats structure definition.
> 
> How about changing the name of the structure member?  Comments suck.

you mean explicit name like implicit_guarantee ? if comments suck, IMHO,
impl_guar is good enough an option for a field that holds implicit
guarantee.
> 
> -- Dave
> 

-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@us.ibm.com   |      .......you may get it.
----------------------------------------------------------------------
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>