From: Christoph Hellwig <hch@infradead.org>
To: shobhit dayal <shobhit@calsoftinc.com>
Cc: hch@infradead.org, christoph@lameter.com,
manfred@colorfullife.com, akpm@osdl.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mm@kvack.org, Shai Fultheim <shai@scalex86.org>
Subject: Re: Fwd: [PATCH] Pageset Localization V2
Date: Thu, 31 Mar 2005 15:32:35 +0100 [thread overview]
Message-ID: <20050331143235.GA18058@infradead.org> (raw)
In-Reply-To: <1112187977.9773.15.camel@kuber>
On Wed, Mar 30, 2005 at 06:36:18PM +0530, shobhit dayal wrote:
> The goal here is to replace the head of a existing list pointed to by
> 'list' with a new head pointed to by 'nlist'.
> First there is a memcpy that copies the contents of list to nlist then
> this macro is called.
> The macro makes sure that if the old head was empty then INIT_LIST_HEAD
> the 'nlist', if not then make sure that the nodes before and after the
> head now correclty point to nlist instead of list.
Which would be much nicer done using INIT_LIST_HEAD on the new head
always and then calling list_replace (of which currently only a _rcu variant
exists).
Note to Christoph: Just duplicating the code doesn't make it better ;-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-03-31 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-30 5:51 Christoph Lameter
2005-03-30 11:14 ` Christoph Hellwig
[not found] ` <bab4333005033003295f487e3d@mail.gmail.com>
2005-03-30 13:06 ` Fwd: " shobhit dayal
2005-03-31 14:32 ` Christoph Hellwig [this message]
2005-03-31 14:47 ` Matthew Wilcox
2005-03-31 15:36 ` Christoph Lameter
2005-03-31 15:53 ` Christoph Lameter
2005-03-31 15:35 ` Christoph Lameter
2005-03-30 13:40 ` Matthew Wilcox
2005-03-31 3:50 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331143235.GA18058@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=shai@scalex86.org \
--cc=shobhit@calsoftinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox