From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 16 Mar 2005 00:37:40 +0100 From: Pavel Machek Subject: Re: [PATCH] Add freezer call in Message-ID: <20050315233740.GE21292@elf.ucw.cz> References: <1110925280.6454.143.camel@desktop.cunningham.myip.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1110925280.6454.143.camel@desktop.cunningham.myip.net.au> Sender: owner-linux-mm@kvack.org Return-Path: To: Nigel Cunningham Cc: Andrew Morton , Linux Memory Management , Linux Kernel Mailing List List-ID: Hi! > This patch adds a freezer call to the slow path in __alloc_pages. It > thus avoids freezing failures in low memory situations. Like the other > patches, it has been in Suspend2 for longer than I can remember. This one seems wrong. What if someone does down(&some_lock_needed_during_suspend); kmalloc() ? If you freeze him during that allocation, you'll deadlock later... Pavel > Signed-of-by: Nigel Cunningham > > diff -ruNp 213-missing-refrigerator-calls-old/mm/page_alloc.c 213-missing-refrigerator-calls-new/mm/page_alloc.c > --- 213-missing-refrigerator-calls-old/mm/page_alloc.c 2005-02-03 22:33:50.000000000 +1100 > +++ 213-missing-refrigerator-calls-new/mm/page_alloc.c 2005-03-16 09:01:28.000000000 +1100 > @@ -838,6 +838,7 @@ rebalance: > do_retry = 1; > } > if (do_retry) { > + try_to_freeze(0); > blk_congestion_wait(WRITE, HZ/50); > goto rebalance; > } -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org