From: Andrew Morton <akpm@osdl.org>
To: Martin Hicks <mort@sgi.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] Move code to isolate LRU pages into separate function
Date: Tue, 15 Mar 2005 22:37:17 -0800 [thread overview]
Message-ID: <20050315223717.2a0f80e6.akpm@osdl.org> (raw)
In-Reply-To: <20050315195452.GE19113@localhost>
Martin Hicks <mort@sgi.com> wrote:
>
> On Mon, Mar 14, 2005 at 04:49:41PM -0500, Martin Hicks wrote:
> > Hi,
> >
> > I noticed that the loop to pull pages out of the LRU lists for
> > processing occurred twice. This just sticks that code into a separate
> > function to improve readability.
> >
> > The patch is against 2.6.11-mm2 but should apply to anything recent.
> > Build and boot tested on sn2.
>
> Whoops. I was double-incrementing scanned, so only half the pages that
> you asked for were being scanned.
>
> This version fixes that and also allows passing in a NULL scanned
> argument if you don't care how many pages were scanned.
>
But neither caller passes in a NULL argument.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-03-16 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 21:49 Martin Hicks
2005-03-15 15:37 ` Marcelo Tosatti
2005-03-15 16:29 ` Marcelo Tosatti
2005-03-15 19:54 ` Martin Hicks
2005-03-16 6:37 ` Andrew Morton [this message]
2005-03-16 15:10 ` Martin Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315223717.2a0f80e6.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=mort@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox