From: Hirokazu Takahashi <taka@valinux.co.jp>
To: raybry@sgi.com
Cc: marcelo.tosatti@cyclades.com, haveblue@us.ibm.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm: memory migration: bug in touch_unmapped_address
Date: Tue, 01 Mar 2005 09:09:04 +0900 (JST) [thread overview]
Message-ID: <20050301.090904.71101313.taka@valinux.co.jp> (raw)
In-Reply-To: <422356AB.4040703@sgi.com>
Hi Ray,
> Hirokazu,
>
> The length field in the call to get_user_pages() from touch_unmapped_pages()
> is incorrectly specified in bytes, not pages.
>
> As a result of this, if you use the migration code to migrate a page, then
> subsequent pages (that are not necessarily currently allocated or mapped)
> can be allocated and mapped as a result of the migration call.
Yes, you're absolutely right.
I'll fix it soon.
> [touch_unmapped_pages() is added by the memory migration code from the memory
> hotplug patch so this is not currently part of the mainline kernel]
>
> See attached patch for the fix.
Thank you,
Hirokazu Takahashi
who is the person looking for new sponsors to help us to
continue developing the memory migration feature.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2005-03-01 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 17:36 Ray Bryant
2005-02-28 13:33 ` Marcelo Tosatti
2005-02-28 18:56 ` Ray Bryant
2005-03-01 0:09 ` Hirokazu Takahashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301.090904.71101313.taka@valinux.co.jp \
--to=taka@valinux.co.jp \
--cc=haveblue@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=raybry@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox