From: Theodore Ts'o <tytso@mit.edu>
To: pmeda@akamai.com
Cc: akpm@osdl.org, jack@suse.cz, linux-mm@kvack.org
Subject: Re: [patch] ext2: Apply Jack's ext3 speedups
Date: Thu, 27 Jan 2005 15:52:34 -0500 [thread overview]
Message-ID: <20050127205233.GB9225@thunk.org> (raw)
In-Reply-To: <200501270722.XAA10830@allur.sanmateo.akamai.com>
On Wed, Jan 26, 2005 at 11:22:39PM -0800, pmeda@akamai.com wrote:
>
> Apply ext3 speedups added by Jan Kara to ext2.
> Reference: http://linus.bkbits.net:8080/linux-2.5/gnupatch@41f127f2jwYahmKm0eWTJNpYcSyhPw
>
This patch isn't right, as it causes ext2_sparse_group(1) to return 0
instead of 1. Block groups number 0 and 1 must always contain a
superblock.
> static int ext2_group_sparse(int group)
> {
> + if (group <= 0)
> + return 1;
Change this to be:
+ if (group <= 1)
+ return 1;
and it should fix the patch (as well as be similar to the ext3
mainline). With this change,
Acked-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-01-27 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-27 7:22 pmeda
2005-01-27 20:52 ` Theodore Ts'o [this message]
2005-01-27 21:11 ` Andrew Morton
2005-01-27 21:41 ` Theodore Ts'o
2005-01-29 1:56 ` Prasanna Meda
2005-01-29 2:00 ` Prasanna Meda
2005-01-29 3:11 ` test_root reorder(Re: [patch] ext2: Apply Jack's ext3 speedups) Prasanna Meda
2005-01-31 9:51 ` Jan Kara
2005-01-31 19:19 ` Prasanna Meda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050127205233.GB9225@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=pmeda@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox