From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 19 Jan 2005 20:29:56 +0100 From: Andi Kleen Subject: Re: BUG in shared_policy_replace() ? Message-ID: <20050119192955.GC26170@wotan.suse.de> References: <41EE9991.6090606@mvista.com> <20050119174506.GH7445@wotan.suse.de> <41EEA575.9040007@mvista.com> <20050119183430.GK7445@wotan.suse.de> <41EEAE04.3050505@mvista.com> <20050119190927.GM7445@wotan.suse.de> <41EEB440.8010108@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41EEB440.8010108@mvista.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Steve Longerbeam Cc: Andi Kleen , Hugh Dickins , linux-mm , linux-kernel , andrea@suse.de, akpm@osdl.org List-ID: On Wed, Jan 19, 2005 at 11:25:52AM -0800, Steve Longerbeam wrote: > > > Andi Kleen wrote: > > >On Wed, Jan 19, 2005 at 10:59:16AM -0800, Steve Longerbeam wrote: > > > > > >>Andi Kleen wrote: > >> > >> > >> > >>>>yeah, 2.6.10 makes sense to me too. But I'm working in -mm2, and > >>>>the new2 = NULL line is missing, hence my initial confusion. Trivial > >>>>patch to -mm2 attached. Just want to make sure it has been, or will be, > >>>>put back in. > >>>> > >>>> > >>>> > >>>> > >>>That sounds weird. Can you figure out which patch in mm removes it? > >>> > >>> > >>> > >>> > >>found it: > >> > >>http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10/2.6.10-mm1/broken-out/mempolicy-optimization.patch > >> > >> > > > >Are you sure? I don't see it touching the new2 free at the end of the > >function. > > > > > > it's not touching the new2 free, it's removing the new2 = NULL which is > the problem. > > - new2 = NULL; Ah, I agree. Yes, it looks like a merging error when merging with Hugh's changes. Thanks for catching this. The line should not be removed. Andrew should I submit a new patch or can you just fix it up? -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org