From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 15 Dec 2004 01:37:07 +0100 From: Andrea Arcangeli Subject: Re: [PATCH] fix spurious OOM kills Message-ID: <20041215003707.GW16322@dualathlon.random> References: <41A08765.7030402@ribosome.natur.cuni.cz> <1101045469.23692.16.camel@thomas> <1101120922.19380.17.camel@tglx.tec.linutronix.de> <41A2E98E.7090109@ribosome.natur.cuni.cz> <1101205649.3888.6.camel@tglx.tec.linutronix.de> <41BF0F0D.4000408@ribosome.natur.cuni.cz> <20041214173858.GJ16322@dualathlon.random> <1103067018.5420.37.camel@npiggin-nld.site> <20041214235549.GT16322@dualathlon.random> <1103069783.3406.97.camel@tglx.tec.linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1103069783.3406.97.camel@tglx.tec.linutronix.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Thomas Gleixner Cc: Nick Piggin , Martin =?utf-8?Q?MOKREJ=C5=A0?= , Andrew Morton , piggin@cyberone.com.au, chris@tebibyte.org, marcelo.tosatti@cyclades.com, LKML , linux-mm@kvack.org, Rik van Riel List-ID: On Wed, Dec 15, 2004 at 01:16:23AM +0100, Thomas Gleixner wrote: > It solves one of the problems, but your fix is really the only complete > fix I have in hands since this thread(s) started. + my simple changes to > the whom to kill selection :) That patch prevents the machine to trigger "early" "suprious" oom kills (I had reports of suprious oom kills myself, oom killer triggered despite lots of swapcache was freeable), so it cannot help when a true oom happens like with your workload. In your workload the oom isn't a suprious error. The two patches to apply are out there (you posted a version that merges both of them and doesn't even require to fix the caller of alloc_pages that should be using GFP_ATOMIC instead of GFP_KERNEL). I would like to fix those callers too from my part ;), but I understand if it's not something for a mainline kernel (at least I'm very glad I didn't have to find this bug in the drivers the hard way ;). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org