From: Andrew Morton <akpm@osdl.org>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: Linux-Kernel@vger.kernel.org, AKPM@osdl.org, linux-mm@kvack.org
Subject: Re: [PATCH]: 3/4 mm/rmap.c cleanup
Date: Sun, 21 Nov 2004 13:14:37 -0800 [thread overview]
Message-ID: <20041121131437.4c3bcee0.akpm@osdl.org> (raw)
In-Reply-To: <16800.47063.386282.752478@gargle.gargle.HOWL>
Nikita Danilov <nikita@clusterfs.com> wrote:
>
> mm/rmap.c:page_referenced_one() and mm/rmap.c:try_to_unmap_one() contain
> identical code that
>
> - takes mm->page_table_lock;
>
> - drills through page tables;
>
> - checks that correct pte is reached.
>
> Coalesce this into page_check_address()
Looks sane, but it comes at a bad time. Please rework and resubmit after
the 4-level pagetable code is merged into Linus's tree, post-2.6.10.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-21 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:44 Nikita Danilov
[not found] ` <m1zn1bmbu3.fsf@clusterfs.com>
2004-11-21 16:14 ` Nikita Danilov
2004-11-21 21:14 ` Andrew Morton [this message]
2004-11-22 14:31 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041121131437.4c3bcee0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Linux-Kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox