From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [PATCH 2/3] higher order watermarks
Date: Wed, 10 Nov 2004 14:23:11 -0200 [thread overview]
Message-ID: <20041110162311.GA12696@logos.cnet> (raw)
In-Reply-To: <20041104085745.GA7186@logos.cnet>
On Thu, Nov 04, 2004 at 06:57:45AM -0200, Marcelo Tosatti wrote:
> The original code didnt had the can_try_harder/gfp_high decrease
> which is now on zone_watermark_ok.
>
> Means that those allocations will now be successful earlier, instead
> of going to the next zonelist iteration. kswapd will not be awake
> when it used to be.
>
> Hopefully it doesnt matter that much. You did this by intention?
Another thing Nick is that now balance_pgdat uses zone_watermark_ok,
and that sums "z->protection[alloc_type]".
if (free_pages <= min + z->protection[alloc_type])
return 0;
Since balance_pgdat calls with alloc_type=0, the code will sum ZONE_DMA
(alloc_type = 0) protection, and it should not.
kswapd should be working on the bare min/low/high watermarks AFAICT,
without the protections.
Comments?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-10 16:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-27 8:00 [PATCH 0/3] teach kswapd about higher order allocations Nick Piggin
2004-10-27 8:00 ` [PATCH 1/3] keep count of free areas Nick Piggin
2004-10-27 8:02 ` [PATCH 2/3] higher order watermarks Nick Piggin
2004-10-27 8:02 ` [PATCH 3/3] teach kswapd about higher order areas Nick Piggin
2004-10-27 8:13 ` Nick Piggin
2004-11-04 8:57 ` [PATCH 2/3] higher order watermarks Marcelo Tosatti
2004-11-04 12:20 ` Nick Piggin
2004-11-04 9:55 ` Marcelo Tosatti
2004-11-05 1:06 ` Nick Piggin
2004-11-04 22:47 ` Marcelo Tosatti
2004-11-05 2:08 ` Andrew Morton
2004-11-05 2:14 ` Nick Piggin
2004-11-04 10:02 ` Marcelo Tosatti
2004-11-05 1:12 ` Nick Piggin
2004-11-10 16:23 ` Marcelo Tosatti [this message]
2004-11-11 1:41 ` Nick Piggin
2004-11-11 10:18 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110162311.GA12696@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox