From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, Nick Piggin <piggin@cyberone.com.au>
Subject: [PATCH] kswapd shall not sleep during page shortage
Date: Tue, 9 Nov 2004 14:46:42 -0200 [thread overview]
Message-ID: <20041109164642.GE7632@logos.cnet> (raw)
Andrew,
I was wrong last time I read balance_pgdat() when I thought kswapd
couldnt sleep under page shortage.
It can, because all_zones_ok is set to "1" inside the
"priority=DEF_PRIORITY; priority >= 0; priority--" loop.
So this patch sets "all_zones_ok" to zero even if all_unreclaimable
is set, avoiding it from sleeping when zones are under page short.
Please apply!
--- linux-2.6.10-rc1-mm2/mm/vmscan.c.orig 2004-11-09 16:38:04.480873424 -0200
+++ linux-2.6.10-rc1-mm2/mm/vmscan.c 2004-11-09 16:38:08.624243536 -0200
@@ -1033,15 +1033,17 @@
if (zone->present_pages == 0)
continue;
- if (zone->all_unreclaimable &&
- priority != DEF_PRIORITY)
- continue;
-
if (!zone_watermark_ok(zone, order,
zone->pages_high, 0, 0, 0)) {
end_zone = i;
- goto scan;
+ all_zones_ok = 0;
}
+
+ if (zone->all_unreclaimable &&
+ priority != DEF_PRIORITY)
+ continue;
+
+ goto scan;
}
goto out;
} else {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next reply other threads:[~2004-11-09 16:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 16:46 Marcelo Tosatti [this message]
2004-11-09 20:19 ` Andrew Morton
2004-11-09 17:41 ` Marcelo Tosatti
2004-11-09 21:33 ` Andrew Morton
2004-11-09 18:26 ` Marcelo Tosatti
2004-11-09 22:22 ` Andrew Morton
2004-11-09 20:31 ` Marcelo Tosatti
2004-11-10 0:28 ` Andrew Morton
2004-11-09 23:16 ` Marcelo Tosatti
2004-11-09 23:34 ` Marcelo Tosatti
2004-11-10 2:53 ` Andrew Morton
2004-11-10 18:14 ` Marcelo Tosatti
2004-11-10 22:08 ` Andrew Morton
2004-11-10 0:56 ` Nick Piggin
2004-11-10 2:49 ` Nick Piggin
2004-11-10 2:56 ` Andrew Morton
2004-11-10 3:12 ` Nick Piggin
2004-11-10 3:18 ` Andrew Morton
2004-11-10 3:27 ` Nick Piggin
2004-11-10 4:15 ` Nick Piggin
2004-11-10 8:17 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041109164642.GE7632@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox