From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 8 Nov 2004 14:27:31 -0200 From: Marcelo Tosatti Subject: Re: [PATCH] Remove OOM killer from try_to_free_pages / all_unreclaimable braindamage Message-ID: <20041108162731.GE2336@logos.cnet> References: <20041105200118.GA20321@logos.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041105200118.GA20321@logos.cnet> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton , Nick Piggin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Fri, Nov 05, 2004 at 06:01:18PM -0200, Marcelo Tosatti wrote: > While doing this, I noticed that kswapd will happily go to sleep > if all zones have all_unreclaimable set. I bet this is the reason > for the page allocation failures we are seeing. So the patch > also makes balance_pgdat() NOT return and go to "loop_again" > instead in case of page shortage - even if all_unreclaimable is set. > > Basically the "loop_again" logic IS NOT WORKING! Wrong, the loop_again logic is working, all_zones_ok will be set when DEF_PRIORITY = 0. So the page allocation failures are happening for some other reason(s). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org