Re: migration cache, updated

[Marcelo Tosatti <marcelo.tosatti@cyclades.com>]

On Thu, Oct 28, 2004 at 11:51:57AM -0700, Dave Hansen wrote:
> Marcelo Tosatti wrote:
> >+static inline int PageMigration(struct page *page)
> >+{
> >+        swp_entry_t entry;
> >+
> >+        if (!PageSwapCache(page))
> >+                return 0;
> >+
> >+        entry.val = page->private;
> >+
> >+        if (swp_type(entry) != MIGRATION_TYPE)
> >+                return 0;
> >+
> >+        return 1;
> >+}
> 
> Don't we usually try to keep the Page*() operations to be strict 
> page->flags checks?  Should this be page_migration() or something 
> similar instead?

Yeah I think page_migration() will be more conformant to the current
macros.

Will do it, and upgrade to the latest -mhp. What is it again? 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>